feat(ui): support custom icons #20864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20864 +/- ##
=========================================
Coverage ? 60.83%
=========================================
Files ? 404
Lines ? 66217
Branches ? 0
=========================================
Hits ? 40281
Misses ? 22695
Partials ? 3241 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
christianh814
approved these changes
Sep 28, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
leoluz
approved these changes
Oct 2, 2025
Collaborator
leoluz
left a comment
leoluz
left a comment
There was a problem hiding this comment.
LGTM besides the check failures.
Signed-off-by: Michael Crenshaw <[email protected]>
todaywasawesome
approved these changes
Oct 2, 2025
Contributor
todaywasawesome
left a comment
todaywasawesome
left a comment
There was a problem hiding this comment.
Brilliant! I know everyone will want to start customizing and adding some of their own but that shouldn't be a blocker for something so useful. Let it merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20636
I've added icons for CNCF projects where we already have at least one resource customization (health script or action) for that resource. I just did that, because it was easier to find CRD group names using our existing customizations.
Here's what the icons look like: