Skip to content

fix: Lint Go code(#12522) #12523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crenshaw-dev merged 2 commits into from
Feb 19, 2023
Merged

fix: Lint Go code(#12522) #12523

crenshaw-dev merged 2 commits into from
Feb 19, 2023

Conversation

@juunini
Copy link
Contributor

@juunini juunini commented Feb 18, 2023 •
edited
Loading

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Description

[ISSUE #12522]
Change io/util to io

@juunini
fix: io/ioutil to io
6494281 
Signed-off-by: juunini <[email protected]>
@juunini juunini marked this pull request as ready for review February 18, 2023 10:40
@juunini juunini mentioned this pull request Feb 18, 2023
Closed
10 tasks
@codecov
Copy link

codecov bot commented Feb 18, 2023 •
edited
Loading

Codecov Report

Base: 47.76% // Head: 47.77% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (32af28b) compared to base (f9a5dae).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #12523   +/-   ##
=======================================
  Coverage   47.76%   47.77%           
=======================================
  Files         246      246           
  Lines       41910    41910           
=======================================
+ Hits        20020    20023    +3     
+ Misses      19891    19889    -2     
+ Partials     1999     1998    -1
Impacted Files Coverage Δ
util/settings/settings.go 49.60% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

34fathombelow
34fathombelow requested changes Feb 18, 2023
View reviewed changes
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep things a little simpler to avoid additional imports.

cmd/argocd/commands/applicationset_test.go
w.Close()

out, err := ioutil.ReadAll(r)
out, err := io.ReadAll(r)
Copy link
Member

@34fathombelow 34fathombelow Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
out, err := io.ReadAll(r)
out, err := os.ReadAll(r)

Copy link
Contributor Author

@juunini juunini Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I was change io.ReadAll to os.ReadAll and remove import io.
But, os.ReadAll is not exists.

so, git reset and force push before commit

34fathombelow
34fathombelow approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks so much for your contribution

@34fathombelow 34fathombelow added the ready-for-review An approver should give a final review and merge the PR label Feb 18, 2023
@crenshaw-dev crenshaw-dev merged commit 9f9a226 into argoproj:master Feb 19, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@juunini @yyzxw
fix: Lint Go code (argoproj#12522) (argoproj#12523)
01afdd7 
* fix: `io/ioutil` to `io`

Signed-off-by: juunini <[email protected]>

* docs: add cloudmate in users

Signed-off-by: juunini <[email protected]>

---------

Signed-off-by: juunini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@34fathombelow 34fathombelow 34fathombelow approved these changes

Assignees

No one assigned

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juunini @crenshaw-dev @34fathombelow