Skip to content

change parity default values to be readable #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

change parity default values to be readable #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ The `DESCRIBE` command returns a description of the communication port. The desc
"parity": {
"label": "Parity",
"type": "enum",
"values": ["N", "E", "O", "M", "S"],
"selected": "N"
"values": ["None", "Even", "Odd", "Mark", "Space"],
"selected": "None"
},
"bits": {
"label": "Data bits",
Expand Down
14 changes: 7 additions & 7 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ func NewSerialMonitor() *SerialMonitor {
"parity": {
Label: "Parity",
Type: "enum",
Values: []string{"N", "E", "O", "M", "S"},
Selected: "N",
Values: []string{"None", "Even", "Odd", "Mark", "Space"},
Selected: "None",
},
"bits": {
Label: "Data bits",
Expand Down Expand Up @@ -152,15 +152,15 @@ func (d *SerialMonitor) getMode() *serial.Mode {
baud, _ := strconv.Atoi(d.serialSettings.ConfigurationParameter["baudrate"].Selected)
var parity serial.Parity
switch d.serialSettings.ConfigurationParameter["parity"].Selected {
case "N":
case "None":
parity = serial.NoParity
case "E":
case "Even":
parity = serial.EvenParity
case "O":
case "Odd":
parity = serial.OddParity
case "M":
case "Mark":
parity = serial.MarkParity
case "S":
case "Space":
parity = serial.SpaceParity
}
dataBits, _ := strconv.Atoi(d.serialSettings.ConfigurationParameter["bits"].Selected)
Expand Down