Skip to content

Fix: various race conditions and packet transmission bugs (and allow multi sub-packets per meta-packet) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Oct 20, 2023
Merged

Fix: various race conditions and packet transmission bugs (and allow multi sub-packets per meta-packet) #30

merged 36 commits into from
Oct 20, 2023

Conversation

aentinger
Copy link
Contributor

No description provided.

@aentinger
Remove dead-code concerning "trigger_irq".
39973b7
@aentinger
Const-correctness 4tw.
6621f11
@aentinger
Save for-loop the first iteration in case of no DEBUG being enabled.
3082e86
@aentinger
Fix: return the number of bytes enqueued - 0, if no bytes have been e…
d7320c9 
…nqueued.
@aentinger
Fix: allow enqeuing of multiple CAN frames before triggering the DMA …
9bbf6fb 
…transfer.
@aentinger
Fix race condition when polling status flag "get_data_amount".
5aabfd9
@aentinger
Extract function for thread-safe determination if a DMA transfer is c…
21d1152 
…omplete.
@aentinger
Rename "get_amount_data" to "is_dma_transfer_complete_flag_temp" whic…
051d782 
…h much better reflects what is actually going on.
@aentinger
Get rid of pretty worthless functions "get_dma_buffer" and "get_dma_b…
739e63e 
…uffer_size".

They only have one functional line and that's either a cast or a sizeof ... hardly worthy of being in a separate function.
@aentinger
Fix: not only the packet header size but also the header checksum nee…
532360b 
…ds to be re-set to its initial value.

Otherwise the next checksum will be calculated in continuation to a value != 0 leading to checksum error detected by the linux driver - simply because the old value had been used for further cheksum calculation, even if this concerns a fully new package.
@aentinger aentinger added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 16, 2023
@aentinger aentinger self-assigned this Oct 16, 2023
@aentinger
Cleanup out-commented code.
1e7039a
@aentinger
Cleanup dead-code.
4624fd8
@aentinger
Group trigger for UART/Virtual UART/CAN/GPIO together. This way the a…
e81c757 
…mount of unncessary packets sent is much reduced.
@aentinger
Rename variable "pkt" to "subpkt" in order to eliminate confusion.
0ddc520
@aentinger
Rename "tx_pkt" to "pkt". Now the code reads much more easier from a …
dd09f4e 
…semantic perspective.
@aentinger
Fix: only trigger IRQ request pin within critical section.
9eb6ca4
@aentinger
Fix: return the number of bytes enqueued.
dfd45c9
@aentinger
Fix: no need to try to read from second CAN bus if the DMA structure …
c1f6146 
…is already full.
@aentinger
Prevent the processing of received packages from unintended interrupt…
14bf8e8 
…ions.
@aentinger
Encapsulate debug output within #ifdef DEBUG ... #endif - no function…
e646d92 
…al change but makes for cleaner code reading.
@aentinger
Cleanup and encapsulate peripheral processing.
7512df7
@aentinger
Delete a couple of declarations w/o definitions.
e1de609
@aentinger
Delete dead (not-even compiled) file crc32.c.
28e6891
@aentinger
Augmenting all peripheral callback functions to return number of byte…
0f5ed96 
…s enqueued.
@aentinger
Inlining writeVersion.
35c2a43
@aentinger
Can only be one opcode at a time.
8157138
@aentinger
Disable direct IRQ trigger for all packages that are now handled in t…
e9339a7 
…he main loop.
@aentinger aentinger marked this pull request as ready for review October 20, 2023 05:02
@aentinger aentinger merged commit a08e21e into master Oct 20, 2023
@aentinger aentinger deleted the enqueue-fine-tuning branch October 20, 2023 07:56
aentinger added a commit to arduino/meta-partner-arduino that referenced this pull request Oct 20, 2023
@aentinger
Integrating superbly fixed x8h7 SPI bridge.
49acc3f 
See arduino/portentax8-stm32h7-fw#30.
@aentinger aentinger mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger