Implement HEAD handler for v2/pkgs/tools/installed (required by frontend)
#844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the server returns 405 when called with HEAD to `v2/pkgs/tools/installed` This breaks the install of the tools
umbynos
added
type: enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 19.09% 19.62% +0.53%
==========================================
Files 46 46
Lines 3635 3684 +49
==========================================
+ Hits 694 723 +29
- Misses 2850 2867 +17
- Partials 91 94 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
csarnataro
approved these changes
Oct 10, 2023
alessio-perugini
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Fix regression
Currently, the frontend runs a HEAD request to the
v2/pkgs/tools/installedendpoint before running the GET request. Probably this broke when we bumped GOA (#815). With agent 1.3.2 the request has 200 as status code. After the bump the status code returned was 405.Since in #815 no change in the design was made, I had to implement a custom method.
no