Skip to content

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 25, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

  • adds the gRPC CleanDownloadCacheDirectory call
  • removes dependency on the configuration package from internal/cli/cache/clean.go

What is the current behavior?

No changes

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Mar 25, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.0.0 milestone Mar 25, 2024
@cmaglie cmaglie self-assigned this Mar 25, 2024
@cmaglie cmaglie force-pushed the cache_clean_grpc_service branch from 0ba2a29 to bebdcce Compare March 25, 2024 13:03
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.54%. Comparing base (67d2c57) to head (bebdcce).

Files Patch % Lines
commands/cache/clean.go 57.14% 2 Missing and 1 partial ⚠️
commands/daemon/daemon.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2572      +/-   ##
==========================================
- Coverage   69.56%   69.54%   -0.02%     
==========================================
  Files         205      206       +1     
  Lines       20255    20264       +9     
==========================================
+ Hits        14090    14093       +3     
- Misses       5049     5054       +5     
- Partials     1116     1117       +1     
Flag Coverage Δ
unit 69.54% <45.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit af85d57 into arduino:master Mar 25, 2024
@cmaglie cmaglie deleted the cache_clean_grpc_service branch March 25, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants