-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Mouse and Keyboard are supported on the Micro #3982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The new Mouse and Keyboard error messages were inaccurate and misleading.
Looks good to me. |
@ORBA, |
A better message could be:
But my preference is to remove completely the reference to the boards and just leave:
|
u2 board also support USB :P Since Mouse and Keyboard are just APIs to generate USB report I'd leave out the USB stuff at all. If you look at my current HID Project dev version I created those APIs modular, so one can use the API so send the data via a Serial pipe to an USB AVR for example. (The IDE hasnt got this, just want to mention it). One of @cmaglie s suggestions should be okay. |
Just found out how clever I am. Compiled my code accidentally for the Uno. #if !defined(USBCON)
#error HID Project can only be used with an USB MCU.
#endif Got: So why do we need this check at all? We can fix this inside the code. (might differ for SAM) |
On Thu, Oct 15, 2015 at 05:18:33AM -0700, Nico wrote:
I'd be perfectly happy to see it removed entirely. I'm a little sad that the requirement placed on my initial dev branch |
Perhaps: 'Mouse' not found. Does your sketch include the line '#include <Mouse.h>'? |
What Keyboardio extended support? The internal Keyboard Mouse APIs are limited and thats intended. Dont know if you followed the other PRs but we decided to keep it simple and functional. I've been working quite a lot now in the HID Project and just dropped an improved Keyboard API in the last commit. Feel free to contribute there or suggest new stuff. Edit: just remove it and use a proper #define like in any other library. No extra fancy stuff for internal libs. Equality you know. |
On Thu, Oct 15, 2015 at 11:25:47AM -0700, Nico wrote:
I'm absolutely thrilled with the core APIs being simple, functional and If I recall correctly, the big things we had that the core didn't yet
Within the next few months, I need to actually get to a proper NKRO Of course, it sounds like you've made tremendous progress while I've
Awesome. I'll check it out. Thank you so much for pushing on all this
|
Everything you mentioned is already working. USB wakeup is inside the core now. The wiki just lacks most information yet. If you think any feature is missing, open an issue at the hid project. |
On Thu, Oct 15, 2015 at 11:54:09AM -0700, Nico wrote:
That's amazingly wonderful news. Thank you! |
@obra your last error sentence looks better, may you update your patch with that one? |
Obsoleted by PR #4018 |
And inside the Mouse.h file I suggest to check if the device is USB capable. Also I am not sure if this check (in the PR) is still required then. I think this check is also a bit "unfair" to 3rd party libraries, because I cannot add such a check. |
The new Mouse and Keyboard error messages were inaccurate and misleading.
I'm thrilled that we're now warning users when they try to make a non-32u4 into a HID device. But we shouldn't steer them only toward one specific board when there are multiple totally legitimate official Arduino/Genuino boards that will work.