Skip to content

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented May 1, 2024

Closes #4956

Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: 54e1062

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 1, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/federation 1.1.30-alpha-20240501143351-54e10620f7fe6327673212b7281dec8dceb30acd npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.2.5-alpha-20240501143351-54e10620f7fe6327673212b7281dec8dceb30acd npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented May 1, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 338      ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 145 kB  14 kB/s
     http_req_blocked...............: avg=4.01µs   min=2µs      med=2.66µs   max=170.88µs p(90)=3.77µs   p(95)=4.13µs 
     http_req_connecting............: avg=659ns    min=0s       med=0s       max=111.53µs p(90)=0s       p(95)=0s     
     http_req_duration..............: avg=54.99ms  min=46.83ms  med=52.14ms  max=139.09ms p(90)=58.74ms  p(95)=85.36ms
       { expected_response:true }...: avg=54.99ms  min=46.83ms  med=52.14ms  max=139.09ms p(90)=58.74ms  p(95)=85.36ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 169
     http_req_receiving.............: avg=139.45µs min=101.48µs med=131.86µs max=386.97µs p(90)=159.92µs p(95)=179.7µs
     http_req_sending...............: avg=25.27µs  min=19.54µs  med=24.28µs  max=70.68µs  p(90)=30.5µs   p(95)=34.76µs
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s     
     http_req_waiting...............: avg=54.82ms  min=46.69ms  med=51.99ms  max=138.72ms p(90)=58.57ms  p(95)=85.2ms 
     http_reqs......................: 169     16.82259/s
     iteration_duration.............: avg=59.42ms  min=50.46ms  med=56.25ms  max=144.81ms p(90)=68.29ms  p(95)=89.2ms 
     iterations.....................: 169     16.82259/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

Copy link
Contributor

github-actions bot commented May 1, 2024

💻 Website Preview

The latest changes are available as preview in: https://8d937ccd.graphql-tools.pages.dev

@ardatan ardatan merged commit 8784f45 into master May 1, 2024
@ardatan ardatan deleted the repro-4956 branch May 1, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a computed property with a non-primitive/non-scalar return type breaks the schema when stitching
1 participant