Skip to content

Conversation

@ardatan
Copy link
Owner

@ardatan ardatan commented Apr 7, 2023

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023

🦋 Changeset detected

Latest commit: 1a85b75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/github-loader Patch
@graphql-tools/url-loader Patch
@graphql-tools/prisma-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 242       ✗ 0  
     data_received..................: 28 MB   2.8 MB/s
     data_sent......................: 104 kB  10 kB/s
     http_req_blocked...............: avg=5.05µs   min=2.9µs   med=3.4µs   max=170.49µs p(90)=4.1µs   p(95)=4.5µs   
     http_req_connecting............: avg=925ns    min=0s      med=0s      max=111.99µs p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=77.89ms  min=66.46ms med=73.85ms max=215.07ms p(90)=85.63ms p(95)=112.33ms
       { expected_response:true }...: avg=77.89ms  min=66.46ms med=73.85ms max=215.07ms p(90)=85.63ms p(95)=112.33ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 121
     http_req_receiving.............: avg=163.99µs min=104.5µs med=134.6µs max=758.8µs  p(90)=244µs   p(95)=273.6µs 
     http_req_sending...............: avg=139.44µs min=17.2µs  med=23.5µs  max=3.52ms   p(90)=33.5µs  p(95)=511.49µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=77.59ms  min=66.32ms med=73.53ms max=214.68ms p(90)=84.38ms p(95)=112.18ms
     http_reqs......................: 121     12.016694/s
     iteration_duration.............: avg=83.18ms  min=70.91ms med=78.87ms max=219.78ms p(90)=91.35ms p(95)=120.3ms 
     iterations.....................: 121     12.016694/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

);
return response;
},
token: 'BAD_TOKEN',

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "BAD_TOKEN" is used as [authorization header](1).
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/github-loader 7.3.28-alpha-20230407140332-1a85b75e npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.68-alpha-20230407140332-1a85b75e npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 7.17.16-alpha-20230407140332-1a85b75e npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

💻 Website Preview

The latest changes are available as preview in: https://81ba99e5.graphql-tools.pages.dev

* A GitHub access token
*/
token: string;
token?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was testing GitHub API, this token is required, otherwise we'd get a 401.

So we might have to keep this as required. 🙂

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I added process.env.GITHUB_TOKEN by default.

@ardatan ardatan merged commit 07589ae into master Apr 7, 2023
@ardatan ardatan deleted the github-fixes branch April 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants