-
-
Notifications
You must be signed in to change notification settings - Fork 833
fix(github/url): add missing user-agent for github and do not accept invalid protocols for UrlLoader #5151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…invalid protocols for UrlLoader
🦋 Changeset detectedLatest commit: 1a85b75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Benchmark Results |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-tools/github-loader |
7.3.28-alpha-20230407140332-1a85b75e |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/prisma-loader |
7.2.68-alpha-20230407140332-1a85b75e |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/url-loader |
7.17.16-alpha-20230407140332-1a85b75e |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://81ba99e5.graphql-tools.pages.dev |
| * A GitHub access token | ||
| */ | ||
| token: string; | ||
| token?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was testing GitHub API, this token is required, otherwise we'd get a 401.
So we might have to keep this as required. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added process.env.GITHUB_TOKEN by default.
related dotansimha/graphql-code-generator#9273