Suppress output of nonzero ranks #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue aragilar#35. Also adds the `-unmute-ranks` option to disable this new behaviour.
|
I couldn't get your tests to run locally, so this is only tested manually for now. |
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 99.19% 99.27% +0.07%
==========================================
Files 3 3
Lines 124 137 +13
==========================================
+ Hits 123 136 +13
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@aragilar Can we merge this? I am more than happy to help maintain this package if you'd like! |
bors bot
added a commit
that referenced
this pull request
Aug 27, 2023
47: Rebased version of #41 r=aragilar a=aragilar Replaces #41 in that the tests run and pass now. Hopefully this cases no breakage. Co-authored-by: Oliver Rausch <[email protected]> Co-authored-by: James Tocknell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #35. Also adds the
-unmute-ranksoption to disable this newbehaviour.