Create separate protoc releases #1837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-protoc-release
branch
from
8d38330 to
0eb4378
Compare
glbrntt
requested changes
Aug 14, 2025
| \"name\": \"protoc v$TAG artifactbundle\", | ||
| \"body\": \"Protoc artifactbundle for version $TAG\", | ||
| \"draft\": true, | ||
| \"prerelease\": false |
There was a problem hiding this comment.
We should make sure this isn't set as the latest release. Looks like you need to set make_latest to false (https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release)
# Motivation In a previous PR, I added a Github workflow and scripts to attach a protoc artifactbundle to the latest draft release. This created a chicken and egg problem since we needed to reference the protoc URL in our Package.swift but the URL wasn't public until we published a release. # Modifications This PR changes the workflow and script so that we create separate protoc-artifactbundle releases with a separate tagging scheme that won't conflict with our normal tags. These releases are only used to distribute protoc artifactbundles. # Result We can now generate the protoc artifactbundle releases that we can reference in our Package.swift without creating this chicken and egg problem.
FranzBusch
force-pushed
the
fb-protoc-release
branch
from
0eb4378 to
44c565d
Compare
glbrntt
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In a previous PR, I added a Github workflow and scripts to attach a protoc artifactbundle to the latest draft release. This created a chicken and egg problem since we needed to reference the protoc URL in our Package.swift but the URL wasn't public until we published a release.
Modifications
This PR changes the workflow and script so that we create separate protoc-artifactbundle releases with a separate tagging scheme that won't conflict with our normal tags. These releases are only used to distribute protoc artifactbundles.
Result
We can now generate the protoc artifactbundle releases that we can reference in our Package.swift without creating this chicken and egg problem.