Disable swiftlint AND swift-format checking #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
approved these changes
Apr 16, 2024
|
@tbkka did you want to do the regeneration to land this? |
|
@tbkka did you want to get this in? |
tbkka
force-pushed
the
tbkka-swiftlint-disable-all
branch
from
f7ea06c to
967b423
Compare
|
Thanks for the reminder! I rebuilt everything and it should be good to go once the tests pass. |
gjcairo
added a commit
to grpc/grpc-swift
that referenced
this pull request
Aug 27, 2024
`swift-protobuf` [released 1.28.0](https://github.com/apple/swift-protobuf/releases/tag/1.28.0) yesterday, and it changed the headers in the generated files to disable `swiftlint` (see apple/swift-protobuf#1627). This means that our CI is now failing the sanity step when it checks the generated files match the expected output of the `generate.sh` script. This PR regenerates the protos with swift-protobuf 1.28.0 to include the updated headers.
glbrntt
pushed a commit
to grpc/grpc-swift-nio-transport
that referenced
this pull request
Sep 20, 2024
`swift-protobuf` [released 1.28.0](https://github.com/apple/swift-protobuf/releases/tag/1.28.0) yesterday, and it changed the headers in the generated files to disable `swiftlint` (see apple/swift-protobuf#1627). This means that our CI is now failing the sanity step when it checks the generated files match the expected output of the `generate.sh` script. This PR regenerates the protos with swift-protobuf 1.28.0 to include the updated headers.
glbrntt
pushed a commit
to grpc/grpc-swift-extras
that referenced
this pull request
Sep 20, 2024
`swift-protobuf` [released 1.28.0](https://github.com/apple/swift-protobuf/releases/tag/1.28.0) yesterday, and it changed the headers in the generated files to disable `swiftlint` (see apple/swift-protobuf#1627). This means that our CI is now failing the sanity step when it checks the generated files match the expected output of the `generate.sh` script. This PR regenerates the protos with swift-protobuf 1.28.0 to include the updated headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We include a comment to suppress checking for swift-format.
Do the same for SwiftLint.
Note: No, I really don't want this to proliferate. The next time someone asks, I should probably tell them to talk to the tool vendor about recognizing other tools' comments.