Skip to content

Work around the Fuzz & Sanitizer issues on the 1.x branch #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Work around the Fuzz & Sanitizer issues on the 1.x branch #1581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
186637c
Revert "make fuzz and sanitizer tests not break CI."
thomasvl Mar 18, 2024
a204b25
Use older base image for sanitizer and fuzz testing.
thomasvl Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,18 +173,19 @@ jobs:
--breakage-allowlist-path known_api_breaks.txt

sanitizer_testing:
# Something likely changed in the base ubuntu image causing failures,
# don't fail the build based on these changes.
# Using older ubuntu image due to issue with newer linux kernel images. When
# changing, see the "container" value below.
# https://github.com/apple/swift-protobuf/issues/1571
continue-on-error: true
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
sanitizer: ["address", "thread"]
swiftpm_config: ["debug", "release"]
container:
image: swift:latest
# Test on the latest Swift release, but forcing the focal image to match the
# ubuntu issue mentioned aboce.
image: swift:focal
steps:
- uses: actions/checkout@v4
- name: Test
Expand All @@ -206,17 +207,18 @@ jobs:
swift test -c ${{ matrix.swiftpm_config }} --sanitize=${{ matrix.sanitizer }} ${EXTRAS:-}

fuzzing_regressions:
# Something likely changed in the base ubuntu image causing failures,
# don't fail the build based on these changes.
# https://github.com/apple/swift-protobuf/issues/1573
continue-on-error: true
runs-on: ubuntu-latest
# Using older ubuntu image due to issue with newer linux kernel images. When
# changing, see the "container" value below.
# https://github.com/apple/swift-protobuf/issues/1571
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
swiftpm_config: ["debug", "release"]
container:
image: swift:latest
# Test on the latest Swift release, but forcing the focal image to match the
# ubuntu issue mentioned aboce.
image: swift:focal
steps:
- uses: actions/checkout@v4
- name: Build
Expand Down