Use JSONDecodingOptions.ignoreUnknownFields to ignore unknown enums.#1345
Merged
thomasvl merged 2 commits intoapple:mainfrom Nov 15, 2022
Merged
Use JSONDecodingOptions.ignoreUnknownFields to ignore unknown enums.#1345thomasvl merged 2 commits intoapple:mainfrom
thomasvl merged 2 commits intoapple:mainfrom
Conversation
thomasvl
force-pushed
the
unknown_enums_json
branch
from
2c8c501 to
ed62321
Compare
tbkka
approved these changes
Nov 15, 2022
Collaborator
|
Nice work! I think we might be missing a couple of test cases, but the core logic looks sound. |
A new conformance test came in protocolbuffers/protobuf@09f4901 that says ignoreUnknownFields should also result in unknown enums being ignored. These changes are based on apple#896. Fixes apple#972.
thomasvl
force-pushed
the
unknown_enums_json
branch
from
ed62321 to
43a6a37
Compare
Collaborator
|
Thank you for adding those. Looks all ready to go! |
Closed
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Mar 26, 2024
…wn_fields is set (#15887) # Motivation This PR fixes failing conformance tests for python with name `IgnoreUnknownEnumStringValue`. The JSON parsing spec was discussed in #7392. Recent equivalent changes for other languages: * Swift: apple/swift-protobuf#1345 * C#: #15758 # Changes - 1st commit is a noop refactoring to make relevant _ConvertScalarFieldValue invocations localized - 2nd commit introduces the child exception of `ParseError` named `EnumStringValueParseError` which is suppressed if `ignore_unknown_fields` is set - 3rd commit updates the conformance test failure lists Closes #15887 COPYBARA_INTEGRATE_REVIEW=#15887 from noom:anton/7392/fix-python-test fbcc93a PiperOrigin-RevId: 619288323
elvisdukaj
pushed a commit
to elvisdukaj/protobuf
that referenced
this pull request
Apr 3, 2024
…wn_fields is set (protocolbuffers#15887) # Motivation This PR fixes failing conformance tests for python with name `IgnoreUnknownEnumStringValue`. The JSON parsing spec was discussed in protocolbuffers#7392. Recent equivalent changes for other languages: * Swift: apple/swift-protobuf#1345 * C#: protocolbuffers#15758 # Changes - 1st commit is a noop refactoring to make relevant _ConvertScalarFieldValue invocations localized - 2nd commit introduces the child exception of `ParseError` named `EnumStringValueParseError` which is suppressed if `ignore_unknown_fields` is set - 3rd commit updates the conformance test failure lists Closes protocolbuffers#15887 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15887 from noom:anton/7392/fix-python-test fbcc93a PiperOrigin-RevId: 619288323
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
…wn_fields is set (protocolbuffers#15887) # Motivation This PR fixes failing conformance tests for python with name `IgnoreUnknownEnumStringValue`. The JSON parsing spec was discussed in protocolbuffers#7392. Recent equivalent changes for other languages: * Swift: apple/swift-protobuf#1345 * C#: protocolbuffers#15758 # Changes - 1st commit is a noop refactoring to make relevant _ConvertScalarFieldValue invocations localized - 2nd commit introduces the child exception of `ParseError` named `EnumStringValueParseError` which is suppressed if `ignore_unknown_fields` is set - 3rd commit updates the conformance test failure lists Closes protocolbuffers#15887 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15887 from noom:anton/7392/fix-python-test fbcc93a PiperOrigin-RevId: 619288323
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Nov 25, 2024
# Motivation This PR fixes failing JSON conformance tests for php with name `IgnoreUnknownEnumStringValue*`. The JSON parsing spec was discussed in #7392. Recent similar changes in other languages: - Python: 86abf35 - Swift: apple/swift-protobuf#1345 - C#: #15758 - C++: #16479 Note: this PR is equivalent to #16743. I had to create a new one since I lost access to noom/protobuf in the meantime (switched companies recently). Closes #19376 COPYBARA_INTEGRATE_REVIEW=#19376 from antongrbin:anton--7392--php-newbranch 641a28a PiperOrigin-RevId: 699989555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new conformance test came in protocolbuffers/protobuf@09f4901 that says ignoreUnknownFields should also result in unknown enums being ignored.
These changes are based on #896.
Fixes #972.