Xcode 16 xcodebuild command line failing

[meavydev]

We use xcodebuild to produce a XCframework for iOS arm / simulator and this is failing in EmitSwiftModule.

The minimum target SDK is set to iOS 16.4.
This is nothing to do with the .proto file, as it is failing in building the source of SwiftProtobuf 1.28.1.

Sources/SwiftProtobufPluginLibrary/Descriptor.swift:1279:34: error: 'self' captured by a closure before all members were initialized

Here is the xcodebuild output in full:

EmitSwiftModule normal x86_64 (in target 'SwiftProtobufPluginLibrary' from project 'SwiftProtobuf')
    cd /Users/shawn/ios/navenioSDK/navenioSDK.xcodeproj
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -emit-module -experimental-skip-non-inlinable-function-bodies-without-types /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/DerivedSources/resource_bundle_accessor.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/CodeGenerator.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/CodeGeneratorParameter.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/CodePrinter.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor+Extensions.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/FeatureResolver.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/FieldNumbers.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/GeneratorOutputs.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Google_Protobuf_Compiler_CodeGeneratorResponse+Extensions.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Google_Protobuf_Edition+Extensions.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Google_Protobuf_SourceCodeInfo+Extensions.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/NamingUtils.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/PluginLibEditionDefaults.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/ProtoCompilerContext.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/ProtoFileToModuleMappings.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/ProvidesDeprecationComment.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/ProvidesLocationPath.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/ProvidesSourceCodeLocation.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/StandardErrorOutputStream.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/StringUtils.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/SwiftLanguage.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/SwiftProtobufInfo.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/SwiftProtobufNamer.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/UnicodeScalar+Extensions.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/plugin.pb.swift /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/swift_protobuf_module_mappings.pb.swift -target x86_64-apple-ios12.0-simulator -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator18.0.sdk -I /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/BuildProductsPath/Release-iphonesimulator -I /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/lib -F /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/BuildProductsPath/Release-iphonesimulator/PackageFrameworks -F /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/BuildProductsPath/Release-iphonesimulator -F /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks -F /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator18.0.sdk/Developer/Library/Frameworks -no-color-diagnostics -enable-library-evolution -g -debug-info-format\=dwarf -dwarf-version\=4 -module-cache-path /Users/shawn/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -suppress-warnings -swift-version 5 -enforce-exclusivity\=checked -O -D SWIFT_PACKAGE -serialize-debugging-options -const-gather-protocols-file /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary_const_extract_protocols.json -enable-experimental-feature DebugDescriptionMacro -plugin-path /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/host/plugins/testing -validate-clang-modules-once -clang-build-session-file /Users/shawn/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -Xcc -working-directory -Xcc /Users/shawn/ios/navenioSDK/navenioSDK.xcodeproj -resource-dir /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift -file-compilation-dir /Users/shawn/ios/navenioSDK/navenioSDK.xcodeproj -Xcc -ivfsstatcache -Xcc /Users/shawn/Library/Developer/Xcode/DerivedData/SDKStatCaches.noindex/iphonesimulator18.0-22A3362-db63dc9361471f152f572502bdbfe70a.sdkstatcache -Xcc -I/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/swift-overrides.hmap -Xcc -I/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/BuildProductsPath/Release-iphonesimulator/include -Xcc -I/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/DerivedSources-normal/x86_64 -Xcc -I/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/DerivedSources/x86_64 -Xcc -I/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/DerivedSources -Xcc -DSWIFT_PACKAGE -no-verify-emitted-module-interface -module-name SwiftProtobufPluginLibrary -frontend-parseable-output -disable-clang-spi -target-sdk-version 18.0 -target-sdk-name iphonesimulator18.0 -external-plugin-path /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/lib/swift/host/plugins\#/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin/swift-plugin-server -external-plugin-path /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/local/lib/swift/host/plugins\#/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin/swift-plugin-server -plugin-path /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/host/plugins -plugin-path /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/local/lib/swift/host/plugins -emit-module-doc-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary.swiftdoc -emit-module-source-info-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary.swiftsourceinfo -emit-module-interface-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary.swiftinterface -emit-private-module-interface-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary.private.swiftinterface -emit-objc-header-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary-Swift.h -serialize-diagnostics-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary-master-emit-module.dia -emit-dependencies-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary-master-emit-module.d -o /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary.swiftmodule -emit-abi-descriptor-path /Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/Build/Intermediates.noindex/ArchiveIntermediates/navenioSDK/IntermediateBuildFilesPath/SwiftProtobuf.build/Release-iphonesimulator/SwiftProtobufPluginLibrary.build/Objects-normal/x86_64/SwiftProtobufPluginLibrary.abi.json
/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor.swift:1279:34: error: 'self' captured by a closure before all members were initialized
    if proto.type == .message && self.features.messageEncoding == .delimited {
                                 ^
/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor.swift:1042:27: note: 'self.type' not initialized
  public private(set) var type: Google_Protobuf_FieldDescriptorProto.TypeEnum
                          ^
/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor.swift:1045:14: note: 'self.label' not initialized
  public let label: Google_Protobuf_FieldDescriptorProto.Label
             ^
/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor.swift:1169:14: note: 'self.oneofIndex' not initialized
  public let oneofIndex: Int32?
             ^
/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor.swift:1208:14: note: 'self.options' not initialized
  public var options: Google_Protobuf_FieldOptions
             ^
/Users/shawn/Library/Developer/Xcode/DerivedData/navenioSDK-enxxnytklicgbcbrnevfykghksjb/SourcePackages/checkouts/swift-protobuf/Sources/SwiftProtobufPluginLibrary/Descriptor.swift:1210:7: note: 'self.proto3Optional' not initialized
  let proto3Optional: Bool

[thomasvl]

I took a quick peek with Xcode 16, building locally all I saw was what #1717 should address.

Can you provide more details about how you're doing your build to get this?

[meavydev]

It looks like taking the source locally will let us build again, but up until now we were using the latest release which was 1.28.1.
Although I took the source before your latest change, so I am guessing something changed in Descriptor.swift after 1.28.1 was released.

[thomasvl]

A swift test or swift build of tags/1.28.1 also only gets me the same warning I was seeing on main. And looking at https://github.com/apple/swift-protobuf/commits/main/Sources/SwiftProtobufPluginLibrary/Descriptor.swift, the only change since 1.28.1 was the swift-format run, so no real code changes.

[meavydev]

Here is the xcodebuild section (both sim and device faiil with the same x86_64 error, so it appears to only be x86_64, not that we need that architecture.

# build for device
echo "Starting build for device"
xcodebuild archive \
-scheme ${FRAMEWORK_NAME} \
-configuration Release \
-destination "generic/platform=iOS" \
-archivePath "${IOS_DEVICE_ARCHIVE_PATH}" \
OTHER_SWIFT_FLAGS=-no-verify-emitted-module-interface \
SKIP_INSTALL=NO \
BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
|| exit 1
echo "Finished build for device"

[thomasvl]

What is FRAMEWORK_NAME? This is done in the Swift Protobuf directory or your own directory that references the Swift Protobuf package?

[thomasvl]

PS - If this is for your framework, I'm not sure why you're building the plugin library (or the plugin) for iOS, that doesn't seem to make sense, as the plugin library is only needed to build a protoc plugin in Swift and that would be for a host os, not for iOS.

[meavydev]

It's nothing to do with SwiftProtobuf, it's our SDK name navenioSDK.
We also aren't actually trying to build SwiftProtobuf, but I guess as it's included as source via a SPM package dependency then xcodebuild builds the source.

[thomasvl]

Sounds like you might need to check your scheme to make sure it isn't accidentally including the Swift Protobuf Plugin Library target.

The errors still don't make sense to me, but without a repro, I don't think anyone beyond your team can really explain what is happening.

[meavydev]

That could be it, as I only included the SwiftProtoBuf source to get round the Xcode 16 problem, so I don't know what's hidden in the xcodeproj file, but I'll have a look on Monday.

I should say I am primarily an Android developer and I'm helping out the iOS team, so I am not a fan of the way everything gets hidden in xcodeproj files...

Thanks for your help.

[meavydev]

I had a quick test today... changing back to the published 1.28.1 and just adding SwiftProtobuf has worked. Well I had to manually tidy up the pbxproj file, as there were actually duplicate entries. I have to say gradle files are just a better solution ;)
Obviously Xcode 16 has changed something as the project was building fine on Xcode 15, but at lease we have solved it.