Skip to content

API break in #135 (1.3.0) #150

@glbrntt

Description

@glbrntt

In spite of #135 (comment), I think the was API actually broken in #135:

This:

@inlinable
public func debug(_ message: @autoclosure () -> Logger.Message,
                  metadata: @autoclosure () -> Logger.Metadata? = nil,
                  file: String = #file, function: String = #function, line: UInt = #line) {
    ...
}

...is not the same as:

@inlinable
public func debug(_ message: @autoclosure () -> Logger.Message,
                  metadata: @autoclosure () -> Logger.Metadata? = nil,
                  source: @autoclosure () -> String? = nil,
                  file: String = #file, function: String = #function, line: UInt = #line) {
    ...
}

We need to retain the old function signatures in addition to the new ones and just forward the implementation from the old to the new.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions