Skip to content

Conversation

@MaxDesiatov
Copy link
Member

@MaxDesiatov MaxDesiatov commented Aug 19, 2025

This library currently has no PR testing for Wasm, even though it's a dependency of other libraries that declare Wasm support. To prevent possible future regressions, let's add Wasm build checks to the CI workflows.

rdar://135961596

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • [N/A] I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • [N/A] I've updated the documentation if necessary.

@MaxDesiatov MaxDesiatov requested a review from lorentey as a code owner August 19, 2025 10:32
@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov MaxDesiatov requested a review from bnbarham August 19, 2025 12:35
@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Member Author

@swift-ci test

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@MaxDesiatov MaxDesiatov merged commit 868884d into main Aug 20, 2025
33 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/wasm branch August 20, 2025 08:47
@lorentey lorentey added this to the 1.3.0 milestone Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants