Skip to content

Conversation

@ozumin
Copy link
Contributor

@ozumin ozumin commented May 20, 2025

I thought the example code for OrderedSet.appending(contentsOf:) should be a.appending(contentsOf: b) instead of a.union(b). Please close this PR if this is intended.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@ozumin ozumin requested a review from lorentey as a code owner May 20, 2025 09:44
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh -- good catch!

@lorentey
Copy link
Member

@swift-ci test

@lorentey lorentey merged commit 4216d2a into apple:main May 21, 2025
23 checks passed
@lorentey lorentey added this to the 1.3.0 milestone May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants