Skip to content

Merge release/1.1 to main #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lorentey merged 10 commits into from
Aug 6, 2024
Merged

Merge release/1.1 to main #410

lorentey merged 10 commits into from
Aug 6, 2024

Conversation

@lorentey
Copy link
Member

@lorentey lorentey commented Aug 6, 2024 •
edited
Loading

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

jmschonfeld and others added 10 commits June 18, 2024 15:09
@jmschonfeld
Install the foundation toolchain module during the static swift build (…
af8349c 
…apple#391)
@jmschonfeld
[CMake] Reduce path lengths in single-module build (apple#392)
3e120b4 
* Eliminate relative paths from the cmake single-module build

* Attempt to reduce length of paths in single module build
@jmschonfeld
[CMake] Reduce the size of the _FoundationCollections module (apple#395)
3d2dc41
@quokkaKyu
add 'final' keyword to class
6b8276e
@lorentey
[BigString] Fix accidentally quadratic BigString.init
5e1fe6e 
When ingesting a `String` instance, `BigString` assumes that the input string has a reasonably efficient UTF-8 view.

Unfortunately, that is very much not the case when the input happens to be backed by a bridged NSString object — it appears that in this case, the ingester loop invokes some operation(s) with linear complexity in the size of the entire input, rendering the ingester’s overall complexity quadratic.

The BigString ingester is only expected to operate within a single chunk at the time. It’s unclear precisely which operation triggers the quadratic behavior; ideally we should figure it out and resolve it with a more targeted fix.

In the meantime, a blunt stopgap fix is to force-transcode the input string to UTF-8 at the time the ingester is initialized. This unnecessarily wastes some (temporary) memory on holding the transcoded string, but it avoids the quadratic cliff.
@lorentey
Merge pull request apple#405 from apple/accidentally-quadratic-BigStr…
2db08b3 
…ing-init

[BigString] Fix accidentally quadratic `BigString.init`
@lorentey
Merge pull request apple#403 from quokkaKyu/release/1.1
293314a 
add 'final' keyword to class
@kateinoigakukun
[CMake] Add support for WebAssembly target architectures
effb335 
To repair the swift-corelibs-foundation build on WebAssembly, we need to
add support for Wasm targets to swift-collections' CMake build system.
@kateinoigakukun
Merge pull request apple#408 from kateinoigakukun/yt/wasm-archs
38602cf 
[CMake] Add support for WebAssembly target architectures
@lorentey
Merge branch 'release/1.1'
5dd817c
@lorentey
Copy link
Member Author

lorentey commented Aug 6, 2024

@swift-ci test

@lorentey lorentey merged commit 11433b6 into apple:main Aug 6, 2024
@lorentey lorentey deleted the merge-release-1.1→main branch August 6, 2024 03:42
@lorentey lorentey added this to the 1.3.0 milestone Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance task

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lorentey @jmschonfeld @quokkaKyu @kateinoigakukun