Skip to content

Conversation

@lorentey
Copy link
Member

@lorentey lorentey commented Jun 5, 2024

Sync main with recent changes that landed on release/1.1.

shahmishal and others added 19 commits April 18, 2024 18:22
…se-1.1

Add post-merge CI support for release/1.1 branch
…e-module

Rename RopeModule to _RopeModule in CMakeLists.txt to match Package.swift
(cherry picked from commit e3954cd)
- Currently OrderedCollections cmake incorrectly list "Utilities/_UnsafeBitSet.swift" instead of "Utilities/_UnsafeBitset.swift", causing build failures
…ections-cmake

Fix the incorrect file name in OrderedCollections cmake file
A non-unique reference to a storage instance can legitimately become unique at any point, due to other references (say, held, by another thread) getting destroyed.

`Deque`’s `ensureUnique` implementation currently invokes the uniqueness check two times in quick succession, expecting it to return false both times. In rare circumstances, this can lead to a spurious trap in concurrent environments.

Fix this by avoiding calling `isUnique` more than once.
[Deque]: Fix bogus assert in Deque._Storage._ensureUnique
[test] TreeDictionary.Keys: Remove stray print that’s flooding test output
We are forced to do this due to an Xcode issue (apple#364) with underscored module names.

This module remains unstable, despite the removal of the underscore. Directly importing it from outside the package remains unsupported. This module and/or its entire contents may go away or change in incompatible ways in any future swift-collections release.
Rename _CollectionsUtilities to InternalCollectionsUtilities
Rope.join has a logic error where it fails to properly ensure uniqueness of child node references before zipping the two b-trees together.

rdar://128450202
[Rope] Fix copy-on-write violation in Rope.join
* Add new single-module and foundation-toolchain-module modes to CMake build

* Fix allowable client flag syntax
# Conflicts:
#	.swiftci/5_10_ubuntu2204
#	.swiftci/5_7_ubuntu2204
#	.swiftci/5_8_ubuntu2204
#	.swiftci/5_9_ubuntu2204
#	.swiftci/nightly_6_0_macos
#	.swiftci/nightly_6_0_ubuntu2204
#	.swiftci/nightly_main_macos
#	.swiftci/nightly_main_ubuntu2204
@lorentey
Copy link
Member Author

lorentey commented Jun 5, 2024

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Jun 6, 2024

D'oh, the manifest needs updates.

error: 'swift-collections': product '_CollectionsUtilities' required by package 'swift-collections' target 'SortedCollections' not found. Did you mean 'InternalCollectionsUtilities'?

@lorentey
Copy link
Member Author

lorentey commented Jun 6, 2024

@swift-ci test

@lorentey lorentey merged commit c60d2f2 into apple:main Jun 7, 2024
@lorentey lorentey deleted the merge.1.1→main branch June 7, 2024 19:16
@lorentey lorentey added this to the 1.3.0 milestone Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants