Bugfix Incorrect Assert in BTree.removeFirst/removeLast #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_BTree.removeFirst(_:)and_BTree.removeLast(_:)contains following incorrect assert:This assertion will cause a crash (in debug mode) when we call one of these functions with the same number of items as the collection contains.
This PR solves this issue by replacing
k < self.countwithk <= self.countin the assert.Checklist
I've added benchmarks covering new functionality (if appropriate).