Skip to content

Conversation

@compnerd
Copy link
Contributor

@compnerd compnerd commented Dec 1, 2023

With this tweak, we should be able to build the package in debug mode even on Windows. We always use the release mode DLL form of the C/C++ runtime on Windows and can build the Swift code in Debug or Release mode optimizations.

With this tweak, we should be able to build the package in debug mode
even on Windows.  We always use the release mode DLL form of the C/C++
runtime on Windows and can build the Swift code in Debug or Release mode
optimizations.
@compnerd compnerd requested a review from lorentey as a code owner December 1, 2023 00:49
@compnerd
Copy link
Contributor Author

compnerd commented Dec 1, 2023

@swift-ci please test

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I think we'll want this to go on release/1.1 (or even release/1.0), so that it can get in a tagged release sometime this decade. 😛 Would you be able to rebase this PR on top of one of those branches?

@compnerd
Copy link
Contributor Author

compnerd commented Dec 8, 2023

@lorentey done - created PRs for release/1.0 and release/1.1 as well.

@lorentey lorentey merged commit cc1c037 into apple:main Dec 8, 2023
@compnerd compnerd deleted the debug branch December 8, 2023 22:13
@lorentey lorentey added this to the 1.3.0 milestone Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants