Skip to content

[Heap] Add methods to replace minimum/maximum (redux) #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lorentey merged 11 commits into from
Oct 12, 2022
Merged

[Heap] Add methods to replace minimum/maximum (redux) #208

lorentey merged 11 commits into from
Oct 12, 2022

Conversation

@lorentey
Copy link
Member

@lorentey lorentey commented Oct 12, 2022

This is reviving #116, eliminating all but the actual method implementations.

I still very much doubt that these will ever be used in actual practice, but I'm weary of asking for demonstrable use cases, so I'd much rather close the book on this PR and move on to working on documenting and/or benchmarking this data structure.

Cc @CTMacUser

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

CTMacUser and others added 11 commits October 7, 2021 22:47
@CTMacUser
Segregate the heap consistency testing code from the precondition code
35e4873 
AFAIK, the previous code had no tests for itself, so the revised code doesn't either.
@CTMacUser
Add heap initializer that takes pre-arranged data
c8e24c3
@CTMacUser
Add methods that change the heap minimum or maximum element
e55e516
@CTMacUser
Remove would-be common initializer
def8b84
@CTMacUser
Restrict access to clear-box initializer
8438c2c 
Remove the initializer's own unit tests, assuming that it will always work instead.
@CTMacUser
Change the clear-box initializer to no longer be fail-able
dec05b9 
If the format of the incoming data does not match that of a heap, a precondition error is flagged instead.
@CTMacUser
Change the expression of preconditions
43e880b
@CTMacUser
Undo segregation of heap consistency tests from precondition code
8be0f19
@lorentey
Merge branch 'heap-replace-extrema' into release/1.1
92d808d
@lorentey
[Heap] Remove unnecessary testing APIs
7138144 
We do not need a _raw initializer in the Heap implementation. The
heapify algorithm will not modify storage if it’s already in the
expected shape, so we can simply define one locally that double checks
that the order remains unchanged.
@lorentey
[Heap] Update docs for replaceMin/replaceMax
1228e9c
@lorentey
Copy link
Member Author

lorentey commented Oct 12, 2022

@swift-ci test

@lorentey lorentey merged commit 5a712f4 into apple:main Oct 12, 2022
@lorentey lorentey mentioned this pull request Oct 12, 2022
Merged
7 tasks
@lorentey lorentey deleted the heap-replace-min-max branch October 13, 2022 23:58
@lorentey lorentey added this to the 1.1.0 milestone Oct 14, 2022
@lorentey lorentey added the Heap Min-max heap module label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Heap Min-max heap module

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lorentey @CTMacUser