Skip to content

LinuxContainer: Allow reuse after being stopped #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Containerization/LinuxContainer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public final class LinuxContainer: Container, Sendable {

mutating func setCreating() throws {
switch self {
case .initialized:
case .initialized, .stopped:
self = .creating(.init())
default:
throw ContainerizationError(
Expand Down
1 change: 1 addition & 0 deletions Sources/Integration/Suite.swift
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ struct IntegrationSuite: AsyncParsableCommand {
"container mount": testMounts,
"nested virt": testNestedVirtualizationEnabled,
"container manager": testContainerManagerCreate,
"container reuse": testContainerReuse,
]

var passed = 0
Expand Down
51 changes: 51 additions & 0 deletions Sources/Integration/VMTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,57 @@ extension IntegrationSuite {
}
}

func testContainerReuse() async throws {
let id = "test-container-reuse"

// Get the kernel from bootstrap
let bs = try await bootstrap()

// Create ContainerManager with kernel and initfs reference
let manager = try ContainerManager(vmm: bs.vmm)
defer {
try? manager.delete(id)
}

let buffer = BufferWriter()
let container = try await manager.create(
id,
image: bs.image,
rootfs: bs.rootfs
) { config in
config.process.arguments = ["/bin/echo", "ContainerManager test"]
config.process.stdout = buffer
}

// Start the container
try await container.create()
try await container.start()

// Wait for completion
var status = try await container.wait()
guard status == 0 else {
throw IntegrationError.assert(msg: "process status \(status) != 0")
}
try await container.stop()

// Recreate things.
try await container.create()
try await container.start()

// Wait for completion.. again.
status = try await container.wait()
guard status == 0 else {
throw IntegrationError.assert(msg: "process status \(status) != 0")
}

let output = String(data: buffer.data, encoding: .utf8)
let expected = "ContainerManager test\nContainerManager test\n"
guard output == expected else {
throw IntegrationError.assert(
msg: "process should have returned '\(expected)' != '\(output ?? "nil")'")
}
}

private func createMountDirectory() throws -> URL {
let dir = FileManager.default.uniqueTemporaryDirectory(create: true)
try "hello".write(to: dir.appendingPathComponent("hi.txt"), atomically: true, encoding: .utf8)
Expand Down