ContainerizationOCI: Add OCI prefix to types #205
+465
−426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
rename-oci-types
branch
3 times, most recently
from
7d1f0e8 to
018844e
Compare
dcantah
force-pushed
the
rename-oci-types
branch
from
018844e to
5cca80f
Compare
A large majority of the types in this package were extremely generically named making it common to have to reference the types as ContainerizationOCI.TheType. This change prefixes all of the core runtime spec, and image spec types with OCI, and then adjusts our code to reference these new names so we still build :) This is a breaking change, but I'd rather pull the bandaid now.
dcantah
force-pushed
the
rename-oci-types
branch
from
5cca80f to
00da297
Compare
|
LGTM after a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
A large majority of the types in this package were extremely generically named making it common to have to reference the types as ContainerizationOCI.TheType. This change prefixes all of the core runtime spec, and image spec types with OCI, and then adjusts our code to reference these new names so we still build :)
This is a breaking change, but I'd rather pull the bandaid now.