-
Notifications
You must be signed in to change notification settings - Fork 189
chore: add bidi test with newser selenium webdriver dependency #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds BiDi (Bidirectional) WebDriver support testing to the Appium .NET client by upgrading the Selenium WebDriver dependency and implementing a basic test to verify BiDi functionality works with Appium.
- Upgraded Selenium.WebDriver dependency from version 4.32.0 to 4.35.0 to support BiDi features
- Added a new BiDi test class for Android that verifies basic BiDi connection and status functionality
- Created a helper method for Android UIAutomator capabilities without app parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/Appium.Net/Appium.Net.csproj | Updates Selenium WebDriver dependency to version 4.35.0 for BiDi support |
test/integration/helpers/Caps.cs | Adds overloaded method for Android UIAutomator capabilities without app parameter |
test/integration/Android/BiDiTests.cs | Implements new test class to verify BiDi functionality with Appium driver |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
List of changes
#953
This PR adds Bidi tests in dotnet to check if it can call Bidi stuff via the selenium deps.
Types of changes
What types of changes are you proposing/introducing to the .NET client?
Put an
x
in the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub