Skip to content

chore: add bidi test with newser selenium webdriver dependency #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Aug 15, 2025

List of changes

#953

This PR adds Bidi tests in dotnet to check if it can call Bidi stuff via the selenium deps.

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Test fix (non-breaking change that improves test stability or correctness)

Documentation

  • Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@github-actions github-actions bot added the Test label Aug 15, 2025
@KazuCocoa KazuCocoa marked this pull request as ready for review August 15, 2025 13:56
@KazuCocoa KazuCocoa changed the title test: add bidi test chore: add bidi test with newser selenium webdriver dependency Aug 15, 2025
@KazuCocoa KazuCocoa requested a review from Dor-bl August 15, 2025 14:34
@KazuCocoa KazuCocoa requested a review from laolubenson August 17, 2025 00:16
@Dor-bl Dor-bl requested a review from Copilot August 26, 2025 11:00
Copilot

This comment was marked as outdated.

Co-authored-by: Copilot <[email protected]>
@github-actions github-actions bot added Chore and removed Test labels Aug 26, 2025
Co-authored-by: Copilot <[email protected]>
@KazuCocoa KazuCocoa requested a review from Copilot August 27, 2025 06:56
Copilot

This comment was marked as outdated.

@KazuCocoa KazuCocoa requested a review from Copilot August 27, 2025 14:30
Copilot

This comment was marked as outdated.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds BiDi (Bidirectional) WebDriver support testing to the Appium .NET client by upgrading the Selenium WebDriver dependency and implementing a basic test to verify BiDi functionality works with Appium.

  • Upgraded Selenium.WebDriver dependency from version 4.32.0 to 4.35.0 to support BiDi features
  • Added a new BiDi test class for Android that verifies basic BiDi connection and status functionality
  • Created a helper method for Android UIAutomator capabilities without app parameter

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Appium.Net/Appium.Net.csproj Updates Selenium WebDriver dependency to version 4.35.0 for BiDi support
test/integration/helpers/Caps.cs Adds overloaded method for Android UIAutomator capabilities without app parameter
test/integration/Android/BiDiTests.cs Implements new test class to verify BiDi functionality with Appium driver

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant