Skip to content

Added default Accept header to introspection query #6616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Added default Accept header to introspection query #6616

merged 1 commit into from
Jul 16, 2025

Conversation

pedromfmachado
Copy link
Contributor

@pedromfmachado pedromfmachado commented Jul 15, 2025 •
edited
Loading

Fix for #6615 suggested by @BoD in this comment.

@apollo-librarian
Copy link

apollo-librarian bot commented Jul 15, 2025 •
edited
Loading

❌ Docs preview failed

The preview failed to build.

Build ID: 13482ecfeb721dcbf296fd32

Errors

General: Failed to fetch GitHub source: OK

@pedromfmachado pedromfmachado changed the base branch from main to release-4.x July 15, 2025 15:02
@pedromfmachado pedromfmachado force-pushed the introspection-default-accept-header branch from bff3929 to 9779322 Compare July 15, 2025 15:03
@pedromfmachado pedromfmachado marked this pull request as ready for review July 15, 2025 15:05
@pedromfmachado pedromfmachado marked this pull request as draft July 15, 2025 15:06
@pedromfmachado pedromfmachado marked this pull request as ready for review July 15, 2025 15:14
@BoD BoD changed the base branch from release-4.x to main July 15, 2025 15:49
@BoD BoD requested a review from a team as a code owner July 15, 2025 15:49
@pedromfmachado
Copy link
Contributor Author

I see you changed the base to main, @BoD, should I align the changes with main and then create a backport PR to version 4?

@BoD
Copy link
Contributor

BoD commented Jul 15, 2025

Thanks a lot!

Sorry, I've changed the target branch to be main as we usually first merge there, and then backport to the maintenance release branch - but it messed up the history. Can you rebase and target main? 🙏

@pedromfmachado pedromfmachado force-pushed the introspection-default-accept-header branch from 3d3da00 to 6d9f518 Compare July 15, 2025 16:00
BoD
BoD approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pedromfmachado
Copy link
Contributor Author

Hey @BoD, it seems the failing test also fails in the main branch. Is there something we should do about it or should it be fixed in a different PR?

@BoD
Copy link
Contributor

BoD commented Jul 16, 2025

Actually I just opened #6618 to fix it 😅. We also have an issue with the docs job - I'll have a look at it.

In any case your fix looks good and not related to the error, I'll merge it now.

@BoD BoD merged commit ba231d0 into apollographql:main Jul 16, 2025
11 of 15 checks passed
@pedromfmachado pedromfmachado deleted the introspection-default-accept-header branch July 16, 2025 08:43
pedromfmachado added a commit to pedromfmachado/apollo-kotlin that referenced this pull request Jul 16, 2025
@pedromfmachado
Added default Accept header to introspection query (apollographql#6616)
b4d191c
This was referenced Jul 16, 2025
Merged
Closed
BoD pushed a commit that referenced this pull request Jul 16, 2025
@pedromfmachado
Added default Accept header to introspection query (#6616) (#6619)
46fc3a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

@martinbonnin martinbonnin Awaiting requested review from martinbonnin martinbonnin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedromfmachado @BoD