Skip to content

[IJ Plugin] Use coroutines in ApolloCodegenService #6477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

[IJ Plugin] Use coroutines in ApolloCodegenService #6477

merged 1 commit into from
Apr 24, 2025

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Apr 24, 2025

Fix for #6459

@BoD BoD requested a review from martinbonnin as a code owner April 24, 2025 09:27
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Apr 24, 2025 •
edited
Loading

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 46dd514b29dbdf7029f41b04

@BoD BoD merged commit 1bd8425 into main Apr 24, 2025
8 checks passed
@BoD BoD deleted the ij-plugin-use-coroutines-in-codegen branch April 24, 2025 09:50
@BoD BoD mentioned this pull request Apr 24, 2025
Closed
BoD added a commit that referenced this pull request Apr 28, 2025
@BoD
Use coroutines in ApolloCodegenService (prevents a crash when calling…
cf21aef 
… getExecutionSettings) (#6477)

(cherry picked from commit 1bd8425)
BoD added a commit that referenced this pull request Apr 28, 2025
@BoD
Use coroutines in ApolloCodegenService (prevents a crash when calling…
e64baef 
… getExecutionSettings) (#6477)

(cherry picked from commit 1bd8425)
@BoD BoD mentioned this pull request Apr 28, 2025
Merged
BoD added a commit that referenced this pull request Apr 28, 2025
@BoD
[4.x] Backport #6460 and #6477 (#6487)
c6be050 
* Use coroutines in ApolloCodegenService (prevents a crash when calling getExecutionSettings) (#6477)

(cherry picked from commit 1bd8425)

* Use a coroutines to prevent an IllegalStateException (see #6459) (#6460)

(cherry picked from commit 75b1cdc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BoD @svc-apollo-docs @martinbonnin