Skip to content

Keep the @RequiresOptIn annotation in the Gradle plugin #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2025
Merged

Keep the @RequiresOptIn annotation in the Gradle plugin #6406

merged 2 commits into from
Mar 5, 2025

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Mar 5, 2025 •
edited
Loading

If we do not keep it, we get those warnings when trying to use it:

> Configure project :runtime
w: file:///Users/martinbonnin/git/apollo-kotlin/tests/runtime/build.gradle.kts:22:5: Annotation 
'com.apollographql.apollo.annotations.ApolloExperimental' is not an opt-in requirement marker, 
therefore its usage in @OptIn is ignored

@martinbonnin martinbonnin requested a review from BoD as a code owner March 5, 2025 14:47
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Mar 5, 2025 •
edited
Loading

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 4cdb75b024db4d8cf32e074c

@martinbonnin martinbonnin marked this pull request as draft March 5, 2025 14:50
@martinbonnin martinbonnin force-pushed the keep-requires-opt-in branch from 01bcc08 to c6f39ce Compare March 5, 2025 15:34
@martinbonnin martinbonnin marked this pull request as ready for review March 5, 2025 15:35
BoD
BoD approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit bfdffdd into main Mar 5, 2025
7 checks passed
@martinbonnin martinbonnin deleted the keep-requires-opt-in branch March 5, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbonnin @svc-apollo-docs @BoD