[v2] GraphQLOperation.Variable Cleanup #699
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the conformance of `Optional` to GraphQLOperationVariableValue`. Any optional operation variables should actually be using `GraphQLNullable` to denote the difference between explictly null and absent values. This prevents us or users from accidentally using `Optional` where we shouldn’t be here. Also adds back commented out tests for encoding of variable values.
|
|
Same issue with tests as #698 it looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the conformance of
Optionalto GraphQLOperationVariableValue`.Any optional operation variables should actually be using
GraphQLNullableto denote the difference between explictly null and absent values. This prevents us or users from accidentally usingOptionalwhere we shouldn’t be here.Also adds back commented out tests for encoding of variable values.