Skip to content

Mark packages as side effect free #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 24, 2018
Merged

Mark packages as side effect free #3458

merged 5 commits into from
May 24, 2018

Conversation

kamilkisiela
Copy link
Contributor

@kamilkisiela kamilkisiela commented May 15, 2018 •
edited by hwillson
Loading

Mostly for webpack 4, it will tree-shake apps more effectively.

Since graphql supports it, it's time for Apollo to do the same :)

Fixes #3356.

@hwillson hwillson self-assigned this May 24, 2018
hwillson
hwillson approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @kamilkisiela!

@hwillson hwillson merged commit e7fb8b1 into master May 24, 2018
@hwillson hwillson deleted the feature/sideEffects branch May 24, 2018 19:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees

@hwillson hwillson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilkisiela @hwillson