Skip to content

fix(#4541): fixed transparent background not appearing with dark mode #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(#4541): fixed transparent background not appearing with dark mode #4542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d9da4
fix(#4541): fixed transparent background not appearing with dark mode
Sebastian-Webster Jun 26, 2024
0d2907b
fixed switching from dark mode to light mode failing
Sebastian-Webster Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/modules/Core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,10 @@ export default class Core {
})

gl.dom.Paper.node.style.background =
cnf.theme.mode === 'dark' && !cnf.chart.background
? 'rgba(0, 0, 0, 0.8)'
cnf.theme.mode === 'dark' && !cnf.chart.background
? '#424242'
: cnf.theme.mode === 'light' && !cnf.chart.background
? '#fff'
: cnf.chart.background

this.setSVGDimensions()
Expand Down
6 changes: 0 additions & 6 deletions src/modules/Theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,6 @@ export default class Theme {
options.chart = options.chart || {}
options.tooltip = options.tooltip || {}
const mode = options.theme.mode
const background = mode === 'dark'
? '#424242'
: mode === 'light'
? '#fff'
: options.chart.background || '#fff'
const palette = mode === 'dark'
? 'palette4'
: mode === 'light'
Expand All @@ -197,7 +192,6 @@ export default class Theme {

options.tooltip.theme = mode || 'light'
options.chart.foreColor = foreColor
options.chart.background = background
options.theme.palette = palette

return options
Expand Down
4 changes: 0 additions & 4 deletions src/modules/settings/Config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,6 @@ export default class Config {
opts.chart.foreColor = '#f6f7f8'
}

if (!opts.chart.background) {
opts.chart.background = '#424242'
}

if (!opts.theme.palette) {
opts.theme.palette = 'palette4'
}
Expand Down
4 changes: 2 additions & 2 deletions src/modules/settings/Options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export default class Options {
speed: 350,
},
},
background: 'transparent',
background: '',
locales: [en],
defaultLocale: 'en',
dropShadow: {
Expand Down Expand Up @@ -1115,7 +1115,7 @@ export default class Options {
},
yaxis: this.yAxis,
theme: {
mode: 'light',
mode: '',
palette: 'palette1', // If defined, it will overwrite globals.colors variable
monochrome: {
// monochrome allows you to select just 1 color and fill out the rest with light/dark shade (intensity can be selected)
Expand Down