Skip to content

shim: refactor nodejs shim to work on node8 or node10 #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

skabbes
Copy link
Contributor

@skabbes skabbes commented Aug 27, 2019

No breaking changes to any code, you can simply specify:

"lambda": {
  "runtime": "nodejs10.x"
}

to select the nodejs 10.x runtime on AWS. The node 8 runtime will continue to work, as the shim is compatible with both versions of node.

I have run this against our company's internal website with no issue (node 8), and will run on node10 this afternoon to burn that in too.

@skabbes
Copy link
Contributor Author

skabbes commented Aug 28, 2019

Several hours on node8, and coming up on 24 hours on a few sites that gets probably 1QPS in aggregate for node10.

Still not sure that "runtime" is the best way to expose whether you want node8 or node10. It is going to be forever confusing due to the "proxy runs on X platform, your code runs Y".

@skabbes
Copy link
Contributor Author

skabbes commented Sep 6, 2019

Over 1 week of testing "in production" on a node.js server running node10. And several "static" sites as well, no problem - all running smoothly.

I used to embed node10 directly in the lambda package, and saved so much extra space not having to do that anymore. Now, I have so much more room for left-pad and similar node_modules!

@tj
Copy link
Member

tj commented Sep 6, 2019

Whoop! I'll check this out again when I'm back from NYC next week!

@tj tj mentioned this pull request Oct 19, 2019
3 tasks
@tj
Copy link
Member

tj commented Oct 21, 2019

merged! thanks man!

@tj tj closed this Oct 21, 2019
@loganpowell
Copy link

Thank you @skabbes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants