-
Notifications
You must be signed in to change notification settings - Fork 9
BREAKING: Move to antlr4 runtime for Typescript #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45
In addition to changes below, this PR also improves the build process, as well as enabling code formatting for TS/Java on commit. Files have been formatted, so changes are quite noisy.
From Changelog:
antlr4ts
to officialantlr4
runtime package.extends
is now required to use antlrListener
/Visitor
types.Exception being to avoid the property initialisation syntax in the antlr generated types:
ES2020
and increased min node version to 16.4.13.2
across both distributions. Same tool now generates both.antlr4
package dep instead matching apex-parser version.CaseInsensitiveInputStream
type now extendsCharStream
and can be constructed fromstring
.Charstream
retained to match Java version.node-dir
dependency - replaced with node fs api.