Skip to content

feat: add ExecCollectValuesWatch #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

paralin
Copy link
Member

@paralin paralin commented Jun 27, 2025

No description provided.

@paralin paralin requested a review from Copilot June 27, 2025 23:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new function, ExecCollectValuesWatch, to asynchronously collect values from a directive and trigger callbacks on value changes.

  • Implements add, remove, and dispose handlers with a broadcast mechanism.
  • Adds a dedicated goroutine to execute callbacks based on changes and idle status.
Comments suppressed due to low confidence (1)

bus/multi.go:315

  • [nitpick] The callback goroutine stops watching on error. Consider updating the function documentation to clearly state that an error returned by the callback terminates further monitoring.
					return // Stop on error

@paralin paralin self-assigned this Jun 27, 2025
@paralin paralin force-pushed the collect-values-watch branch from e6701c8 to 8ffa7de Compare June 27, 2025 23:56
Signed-off-by: Christian Stewart <[email protected]>
@paralin paralin force-pushed the collect-values-watch branch from 8ffa7de to 9bdf592 Compare June 29, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant