Skip to content

chore: disable role and phase available conditions when probe is set explicitly #9684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: disable role and phase available conditions when probe is set explicitly #9684

wants to merge 1 commit into from
+6 −2

Conversation

leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf requested a review from a team as a code owner August 29, 2025 08:32
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 29, 2025
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@leon-inf leon-inf requested a review from cjc7373 August 29, 2025 08:32
@leon-inf leon-inf added this to the Release 1.1.0 milestone Aug 29, 2025
@leon-inf
Copy link
Contributor Author

/pick release-1.0

@apecloud-bot apecloud-bot added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Aug 29, 2025
@cjc7373
Copy link
Contributor

cjc7373 commented Aug 29, 2025

I suggest add a validation in cmpd controller to disallow both fields to be set, and also clarify this behaviour in api docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjc7373 cjc7373 Awaiting requested review from cjc7373

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@leon-inf @apecloud-bot @cjc7373