TIKA-4598: Move tika-pipes-ignite from plugin to standalone module #2499
+7
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Relocated from tika-pipes/tika-pipes-plugins/tika-pipes-ignite to tika-pipes/tika-pipes-config-store-ignite - Changed parent from tika-pipes-plugins to tika-pipes - Removed plugin.properties and IgnitePipesPlugin class - Updated module name from tika-pipes-ignite to tika-pipes-config-store-ignite - Module is now directly under tika-pipes alongside other config stores - All tests passing
to tika-pipes-config-store-ignite - Updated artifact ID in three locations - Removed ZIP artifact copy (no longer a plugin, doesn't produce ZIP)
Contributor
Author
|
Fixed the build error by updating tika-grpc/pom.xml:
Build now succeeds: ✅ BUILD SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move tika-pipes-ignite from the plugins directory to a standalone config store module.
Changes
tika-pipes/tika-pipes-plugins/tika-pipes-ignite→tika-pipes/tika-config-stores/tika-config-store-ignitetika-pipes-pluginstotika-config-storessrc/main/resources/META-INF/servicesplugin descriptorTikaPipesIgnitePluginclasstika-pipes-ignite→tika-config-store-igniteRationale
Since Ignite is no longer loaded as a plugin (it's a built-in config store factory), the plugin infrastructure is unnecessary. This simplifies the module structure and makes it consistent with other config store implementations.
Testing
Closes https://issues.apache.org/jira/browse/TIKA-4598