TIKA-4598: Move tika-pipes-ignite to tika-pipes level and remove plugin architecture #2496
+2
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in architecture - Moved tika-pipes-ignite from tika-pipes-plugins to tika-pipes - Removed plugin-specific configuration (assembly, plugin.properties) - Removed @extension annotation from IgniteConfigStoreFactory - Removed IgnitePipesPlugin class - Changed parent from tika-pipes-plugins to tika-pipes - Removed plugin exclusion properties - Changed scoped dependencies to compile scope - This makes Ignite a standard module instead of a PF4J plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors tika-pipes-ignite to be a standard module at the tika-pipes level instead of a PF4J plugin.
Changes
tika-pipes/tika-pipes-plugins/tika-pipes-ignitetotika-pipes/tika-pipes-igniteplugin.propertiesassembly.xmlIgnitePipesPluginclass@Extensionannotation fromIgniteConfigStoreFactorytika-pipes-pluginstotika-pipesprovidedscope to normal scopeRationale
Since Ignite is now used directly by tika-grpc (not as a plugin), it makes more sense for it to be a standard module at the pipes level rather than maintaining the plugin architecture overhead.
Testing
Closes #TIKA-4598