TIKA-4594: Make PipesServer share ConfigStore with TikaGrpcServerImpl #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PipesServer now creates and uses the same type of ConfigStore configured in PipesConfig, allowing runtime fetcher/emitter configurations saved via gRPC endpoints to be available to forked worker processes. This fixes FetcherNotFoundException errors when using saveFetcher followed by fetchAndParse in tika-grpc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes runtime fetcher/emitter configuration sharing between TikaGrpcServerImpl and forked PipesServer workers.
Problem
When using tika-grpc, fetchers and emitters saved via the gRPC
saveFetcher/saveEmitterendpoints were not available to the forked PipesServer workers because they used separate ConfigStore instances. This causedFetcherNotFoundExceptionerrors when callingfetchAndParseaftersaveFetcher.Solution
Modified
PipesServer.initializeResources()to:trueto the load methodsChanges
createConfigStore()helper method to instantiate ConfigStore from PipesConfiginitializeResources()to create and use ConfigStore for FetcherManager and EmitterManagerTesting
This enables the tika-grpc-e2e-test suite to properly test fetcher/emitter lifecycle through gRPC.
JIRA: https://issues.apache.org/jira/browse/TIKA-4594