TIKA-4581: Fix packaging issues and allow plugin-roots override #2486
+298
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --plugin-roots command-line parameter to override plugin-roots from config file. Problem: Users had to include 'plugin-roots' in tika-config.json file, which made Docker deployments less flexible. Different environments might need different plugin locations. Solution: - Added --plugin-roots CLI parameter to TikaGrpcServer - Parameter accepts comma-separated list of plugin directories - CLI parameter overrides config file if specified - Falls back to config file if not specified Changes: - TikaGrpcServer: Added --plugin-roots parameter - TikaGrpcServerImpl: Updated constructor to accept pluginRootsOverride - TikaPluginManager: Added loadFromPaths() method for string-based paths Usage: java -jar tika-grpc.jar -c config.json --plugin-roots /tmp/tika-plugins Or Docker: docker run apache/tika-grpc:latest -c /config/config.json --plugin-roots /tmp/tika-plugins Benefits: - No need to modify config files for different environments - Simplifies Docker/Kubernetes deployments - Backward compatible - config file still works if CLI not specified
Adds all 13 plugin modules to the copy-plugins execution: - tika-pipes-az-blob - tika-pipes-csv - tika-pipes-gcs - tika-pipes-ignite - tika-pipes-jdbc - tika-pipes-json - tika-pipes-kafka - tika-pipes-microsoft-graph - tika-pipes-opensearch - tika-pipes-s3 - tika-pipes-solr This ensures all plugins are available for Docker builds.
The assembly.xml was trying to include MANIFEST.MF from classes/ directory but it only exists in the JAR file. Changed to use dependencySet with unpack to properly extract MANIFEST.MF and extensions.idx from the project artifact JAR into the plugin ZIP. This fixes 'Cannot find the manifest path' errors for these 3 plugins.
The plugin.properties referenced the wrong class name: Wrong: org.apache.tika.pipes.emitter.gcs.GCSEmitterPlugin Correct: org.apache.tika.pipes.plugin.gcs.GCSPipesPlugin This caused ClassNotFoundException when loading the GCS plugin.
nddipiazza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users had to include
plugin-rootsin tika-config.json file, which made Docker deployments less flexible. Additionally, several plugin packaging issues prevented proper plugin loading.Solutions
1. Added --plugin-roots CLI parameter
Added
--plugin-rootscommand-line parameter that overrides config file.Usage:
2. Fixed plugin assembly descriptors
Fixed MANIFEST.MF packaging for 3 plugins (az-blob, gcs, jdbc) that were failing with "Cannot find the manifest path" errors.
Root cause: Assembly descriptors tried to include MANIFEST.MF from
classes/directory, but it only exists in the JAR.Solution: Use
<dependencySet>with<unpack>to extract MANIFEST.MF from the project JAR.3. Fixed GCS plugin.properties
Corrected plugin class reference:
org.apache.tika.pipes.emitter.gcs.GCSEmitterPluginorg.apache.tika.pipes.plugin.gcs.GCSPipesPluginResults
✅ All 13 plugins now load successfully in tika-grpc-docker
✅ Flexible Docker/Kubernetes deployments
✅ Backward compatible
Testing
Verified with tika-grpc-docker that all plugins resolve and start: