Skip to content

TIKA-4350 HTML snippet containing <iframe> as root element erroneously recognized as application/xml #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tballison merged 1 commit into from
Nov 14, 2024
Merged

TIKA-4350 HTML snippet containing <iframe> as root element erroneously recognized as application/xml #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7680,6 +7680,8 @@
<root-XML localName="SCRIPT"/>
<root-XML localName="frameset"/>
<root-XML localName="FRAMESET"/>
<root-XML localName="iframe"/>
<root-XML localName="IFRAME"/>
<magic priority="60">
<match value="(?i)&lt;(html|head|body|title|div)[ >]" type="regex" offset="0"/>
<match value="(?i)&lt;h[123][ >]" type="regex" offset="0"/>
Expand Down
2 changes: 2 additions & 0 deletions tika-core/src/test/java/org/apache/tika/mime/MimeDetectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ public void testDetection() throws Exception {
testFile("text/html", "testlargerbuffer.html");
// test fragment of HTML with <div> (TIKA-1102)
testFile("text/html", "htmlfragment");
// test fragment of HTML with <iframe> and potentially misleading file suffix
testFile("text/html", "test-html-snippet-iframe.jsp");
// test binary CGM detection (TIKA-1170)
testFile("image/cgm", "plotutils-bin-cgm-v3.cgm");
// test HTML detection of malformed file, previously identified as image/cgm (TIKA-1170)
Expand Down
2 changes: 2 additions & 0 deletions tika-core/src/test/resources/org/apache/tika/mime/test-html-snippet-iframe.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<!-- this is a comment: https://www.example.org/path/file.pdf -->
<iframe src='/path/file.pdf' width='100%' height='100%' target='_blank'>
Loading