Skip to content

build(dev-deps): move Webpack-dedicated js-yaml-loader to dev deps section - #37788

Merged
rusackas merged 1 commit into
masterfrom
chore/move-js-yaml-loader-to-dev-deps
Feb 8, 2026
Merged

build(dev-deps): move Webpack-dedicated js-yaml-loader to dev deps section#37788
rusackas merged 1 commit into
masterfrom
chore/move-js-yaml-loader-to-dev-deps

Conversation

@hainenber

Copy link
Copy Markdown
Contributor

build(dev-deps): move Webpack-dedicated js-yaml-loader to dev deps section

SUMMARY

js-yaml-loader is only used for building bundled assets by Webpack so it would be pretty alien to have it as runtime dep. This PR is to move it to devDependencies section for clarity of purpose and to reduce vulnerability attack surface.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…section

Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review

bito-code-review Bot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

"@emotion/cache": "^11.4.0",
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.14.1",
"@luma.gl/constants": "~9.2.5",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only alphabetic re-ordering of dependencies. It's safe

@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

Sequence Diagram

The PR moves the Webpack-only package js-yaml-loader from runtime dependencies to devDependencies so it is only installed for development/builds. The diagram shows the change flow from manifest update to build-time use and absence at runtime.

sequenceDiagram
    participant Dev as Developer / PR
    participant Repo as package.json & package-lock.json
    participant PM as Package Manager (npm/yarn)
    participant Build as Webpack build
    participant Runtime as Production runtime

    Dev->>Repo: Modify manifests (move js-yaml-loader to devDependencies)
    Repo->>PM: package-lock updated / install metadata marked dev
    PM->>Build: Install devDependencies for CI/local build
    Build->>PM: Use js-yaml-loader during asset bundling
    Note over Runtime,PM: js-yaml-loader not included in production runtime installs
    Runtime-->>Build: Serve bundled assets (no runtime dependency on js-yaml-loader)
Loading

Generated by CodeAnt AI

@bito-code-review

Copy link
Copy Markdown
Contributor

The changes in package.json add several @luma.gl dependencies and remove js-yaml-loader from runtime dependencies. In package-lock.json, js-yaml-loader is moved to devDependencies with related packages marked as dev. This is more than alphabetic reordering and involves functional updates, but appears safe for dependency management.

@rusackas
rusackas merged commit c4d2d42 into master Feb 8, 2026
75 of 76 checks passed
@rusackas
rusackas deleted the chore/move-js-yaml-loader-to-dev-deps branch February 8, 2026 09:37
aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Mar 5, 2026
…section (apache#37788)

Signed-off-by: hainenber <dotronghai96@gmail.com>
alex-poor pushed a commit to alex-poor/superset that referenced this pull request Mar 15, 2026
…section (apache#37788)

Signed-off-by: hainenber <dotronghai96@gmail.com>
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…section (apache#37788)

Signed-off-by: hainenber <dotronghai96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants