build(dev-deps): move Webpack-dedicated js-yaml-loader to dev deps section - #37788
Conversation
…section Signed-off-by: hainenber <dotronghai96@gmail.com>
|
Bito Automatic Review Skipped - Files Excluded |
| "@emotion/cache": "^11.4.0", | ||
| "@emotion/react": "^11.14.0", | ||
| "@emotion/styled": "^11.14.1", | ||
| "@luma.gl/constants": "~9.2.5", |
There was a problem hiding this comment.
This is only alphabetic re-ordering of dependencies. It's safe
Sequence DiagramThe PR moves the Webpack-only package js-yaml-loader from runtime dependencies to devDependencies so it is only installed for development/builds. The diagram shows the change flow from manifest update to build-time use and absence at runtime. sequenceDiagram
participant Dev as Developer / PR
participant Repo as package.json & package-lock.json
participant PM as Package Manager (npm/yarn)
participant Build as Webpack build
participant Runtime as Production runtime
Dev->>Repo: Modify manifests (move js-yaml-loader to devDependencies)
Repo->>PM: package-lock updated / install metadata marked dev
PM->>Build: Install devDependencies for CI/local build
Build->>PM: Use js-yaml-loader during asset bundling
Note over Runtime,PM: js-yaml-loader not included in production runtime installs
Runtime-->>Build: Serve bundled assets (no runtime dependency on js-yaml-loader)
Generated by CodeAnt AI |
|
The changes in package.json add several @luma.gl dependencies and remove js-yaml-loader from runtime dependencies. In package-lock.json, js-yaml-loader is moved to devDependencies with related packages marked as dev. This is more than alphabetic reordering and involves functional updates, but appears safe for dependency management. |
…section (apache#37788) Signed-off-by: hainenber <dotronghai96@gmail.com>
…section (apache#37788) Signed-off-by: hainenber <dotronghai96@gmail.com>
…section (apache#37788) Signed-off-by: hainenber <dotronghai96@gmail.com>
build(dev-deps): move Webpack-dedicated
js-yaml-loaderto dev deps sectionSUMMARY
js-yaml-loaderis only used for building bundled assets by Webpack so it would be pretty alien to have it as runtime dep. This PR is to move it todevDependenciessection for clarity of purpose and to reduce vulnerability attack surface.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION