Skip to content

chore(deps): update dompurify requirement from ^3.3.0 to ^3.3.1 in /superset-frontend/plugins/legacy-preset-chart-nvd3 - #36471

Merged
rusackas merged 3 commits into
masterfrom
dependabot/npm_and_yarn/superset-frontend/plugins/legacy-preset-chart-nvd3/dompurify-tw-3.3.1
Dec 11, 2025
Merged

chore(deps): update dompurify requirement from ^3.3.0 to ^3.3.1 in /superset-frontend/plugins/legacy-preset-chart-nvd3#36471
rusackas merged 3 commits into
masterfrom
dependabot/npm_and_yarn/superset-frontend/plugins/legacy-preset-chart-nvd3/dompurify-tw-3.3.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Dec 9, 2025

Copy link
Copy Markdown
Contributor

User description

Updates the requirements on dompurify to permit the latest version.

Release notes

Sourced from dompurify's releases.

DOMPurify 3.3.1

  • Updated ADD_FORBID_CONTENTS setting to extend default list, thanks @​MariusRumpf
  • Updated the ESM import syntax to be more correct, thanks @​binhpv
Commits
  • 6fc446a Merge pull request #1175 from cure53/main
  • 3b3bf91 Merge branch 'main' of github.com:cure53/DOMPurify
  • 9863f41 chore: Preparing 3.3.1 release
  • b4e0295 chore: Preparing 3.3.0 release
  • 077746b build(deps-dev): bump js-yaml from 4.1.0 to 4.1.1 (#1170)
  • 4de68bb build(deps): bump actions/checkout from 5 to 6 (#1171)
  • 4c76b6f Use correct ESM import syntax (#1173)
  • 27e8496 Merge pull request #1168 from MariusRumpf/add-forbid-contents
  • a920096 Add ADD_FORBID_CONTENTS setting to extend default list
  • ac64660 Merge pull request #1163 from cure53/dependabot/github_actions/actions/setup-...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

CodeAnt-AI Description

Update DOMPurify to v3.3.1 for the legacy NVD3 chart plugin

What Changed

  • The legacy-preset-chart-nvd3 package now allows DOMPurify version 3.3.1 instead of 3.3.0
  • Charts using this plugin will pick up DOMPurify's updated defaults (including an extended forbidden-contents list and corrected ESM import behavior) when the dependency is installed or updated

Impact

✅ Stricter HTML sanitization in legacy NVD3 charts
✅ Fewer XSS risks when rendering chart tooltips or labels
✅ Compatibility with updated ESM import syntax

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@dependabot dependabot Bot added dependabot npm Dependabot - npm related PRs labels Dec 9, 2025
@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

CodeAnt AI is reviewing your PR.

@bito-code-review

bito-code-review Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@codeant-ai-for-open-source codeant-ai-for-open-source Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Dec 9, 2025
@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

CodeAnt AI finished reviewing your PR.

@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

💡 Enhance Your PR Reviews

We noticed that 3 feature(s) are not configured for this repository. Enabling these features can help improve your code quality and workflow:

🚦 Quality Gates

Status: Quality Gates are not enabled at the organization level
Learn more about Quality Gates

🎫 Jira Ticket Compliance

Status: Jira credentials file not found. Please configure Jira integration in your settings
Learn more about Jira Integration

⚙️ Custom Rules

Status: No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository
Learn more about Custom Rules


Want to enable these features? Contact your organization admin or check our documentation for setup instructions.

@rusackas
rusackas self-requested a review December 9, 2025 18:27
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/superset-frontend/plugins/legacy-preset-chart-nvd3/dompurify-tw-3.3.1 branch from 2a621b7 to 5d6caf7 Compare December 11, 2025 01:01
@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

CodeAnt AI is running Incremental review

@rusackas
rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/plugins/legacy-preset-chart-nvd3/dompurify-tw-3.3.1 branch from 5d6caf7 to dde5545 Compare December 11, 2025 04:20
@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

Skipping PR review because a bot author is detected.

If you want to trigger CodeAnt AI, comment @codeant-ai review to trigger a manual review.

dependabot Bot and others added 3 commits December 11, 2025 10:19
Updates the requirements on [dompurify](https://github.com/cure53/DOMPurify) to permit the latest version.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.3.0...3.3.1)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.3.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)
@rusackas
rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/plugins/legacy-preset-chart-nvd3/dompurify-tw-3.3.1 branch from fdb1e1e to 71015b9 Compare December 11, 2025 18:19
@rusackas
rusackas merged commit 955953b into master Dec 11, 2025
63 checks passed
@rusackas
rusackas deleted the dependabot/npm_and_yarn/superset-frontend/plugins/legacy-preset-chart-nvd3/dompurify-tw-3.3.1 branch December 11, 2025 19:23
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…uperset-frontend/plugins/legacy-preset-chart-nvd3 (apache#36471)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@rusackas.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependabot dependencies:npm npm Dependabot - npm related PRs plugins size/XS size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant