Skip to content

fix: core mcp injection and ephemeral envs - #36440

Merged
michael-s-molina merged 2 commits into
apache:masterfrom
preset-io:fix/core-mcp-injection
Dec 5, 2025
Merged

fix: core mcp injection and ephemeral envs#36440
michael-s-molina merged 2 commits into
apache:masterfrom
preset-io:fix/core-mcp-injection

Conversation

@dpgaspar

@dpgaspar dpgaspar commented Dec 5, 2025

Copy link
Copy Markdown
Member

SUMMARY

Fixes ephemeral envs and the docker-init.sh flow.

Was erroring with:

from superset.core.mcp.core_mcp_injection import (
ModuleNotFoundError: No module named 'superset.core.mcp'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CodeAnt-AI Description

Make core MCP package importable to prevent runtime errors in ephemeral environments

What Changed

  • Added the core MCP package so the codebase can load it without failing at startup
  • Prevents runtime errors that occurred when ephemeral environments or injections referenced the missing package
  • No user-facing UI changes

Impact

✅ Fewer startup import errors in ephemeral environments
✅ Prevents runtime failures during core MCP injection
✅ Enables MCP-related code to be discovered at runtime

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

CodeAnt AI is reviewing your PR.

@bito-code-review

bito-code-review Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Code Review Agent Run #f104b8

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 4d879c8..4d879c8
    • superset/core/mcp/__init__.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot Bot added the change:backend Requires changing the backend label Dec 5, 2025
@codeant-ai-for-open-source codeant-ai-for-open-source Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Dec 5, 2025
@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

CodeAnt AI finished reviewing your PR.

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

⚠️ DEPRECATED WORKFLOW ⚠️

@dpgaspar This workflow is deprecated! Please use the new Superset Showtime system instead:

Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

@codecov

codecov Bot commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.99%. Comparing base (45a4239) to head (46d80f6).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #36440       +/-   ##
===========================================
+ Coverage        0   67.99%   +67.99%     
===========================================
  Files           0      635      +635     
  Lines           0    46827    +46827     
  Branches        0     5082     +5082     
===========================================
+ Hits            0    31840    +31840     
- Misses          0    13717    +13717     
- Partials        0     1270     +1270     
Flag Coverage Δ
hive 43.71% <ø> (?)
mysql 67.05% <ø> (?)
postgres 67.10% <ø> (?)
presto 47.36% <ø> (?)
python 67.96% <ø> (?)
sqlite 66.81% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@dpgaspar Ephemeral environment spinning up at http://44.244.210.140:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

⚠️ DEPRECATED WORKFLOW ⚠️

@dpgaspar This workflow is deprecated! Please use the new Superset Showtime system instead:

Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@dpgaspar Ephemeral environment spinning up at http://54.218.68.103:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@michael-s-molina
michael-s-molina merged commit 1d9c93a into apache:master Dec 5, 2025
75 of 76 checks passed
@dpgaspar
dpgaspar deleted the fix/core-mcp-injection branch December 5, 2025 18:44
Facyla pushed a commit to Facyla/superset-contrib that referenced this pull request Dec 16, 2025
aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Jan 17, 2026
aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Jan 24, 2026
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:backend Requires changing the backend size/M size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants