Skip to content

fix: CI failures caused by a ruff version mismatch - #36358

Merged
michael-s-molina merged 9 commits into
apache:masterfrom
michael-s-molina:fix-ruff-error
Dec 1, 2025
Merged

fix: CI failures caused by a ruff version mismatch#36358
michael-s-molina merged 9 commits into
apache:masterfrom
michael-s-molina:fix-ruff-error

Conversation

@michael-s-molina

@michael-s-molina michael-s-molina commented Dec 1, 2025

Copy link
Copy Markdown
Member

SUMMARY

Fixes CI failures caused by a ruff version mismatch between requirements/development.txt (0.8.0) and .pre-commit-config.yaml (0.9.7). The two versions format code differently, causing "files were modified by this hook" failures when CI runs pre-commit.

Changes:

  • Switches ruff pre-commit hooks from external repo to local hooks that use the system-installed ruff
  • Updates pinned ruff version in requirements from 0.8.0 to 0.9.7
  • Excludes docker/* from isort checks. These configuration files import superset_config, a local module in the same directory. Ruff's import classification varies by environment: locally it's classified as local-folder, while on CI (after dependencies are installed) it's classified as third-party. This causes ruff to want a blank line between imports locally but no blank line on CI, resulting in conflicting fixes. Excluding docker config files from isort avoids this environment-dependent inconsistency.

This ensures local development and CI always use the same ruff version, preventing future drift.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review

bito-code-review Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Code Review Agent Run #f6dc51

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: fd01930..fd01930
    • docker/pythonpath_dev/superset_config_docker_light.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Dec 1, 2025
@michael-s-molina michael-s-molina changed the title fix: Lint error in docker/pythonpath_dev/superset_config_docker_light.py fix: CI failures caused by a ruff version mismatch Dec 1, 2025
@codecov

codecov Bot commented Dec 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.99%. Comparing base (9fc7a83) to head (3eae713).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #36358       +/-   ##
===========================================
+ Coverage        0   67.99%   +67.99%     
===========================================
  Files           0      636      +636     
  Lines           0    46824    +46824     
  Branches        0     5083     +5083     
===========================================
+ Hits            0    31837    +31837     
- Misses          0    13707    +13707     
- Partials        0     1280     +1280     
Flag Coverage Δ
hive 43.74% <ø> (?)
mysql 67.09% <ø> (?)
postgres 67.14% <ø> (?)
presto 47.35% <ø> (?)
python 67.96% <ø> (?)
sqlite 66.76% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michael-s-molina
michael-s-molina merged commit b12f5f8 into apache:master Dec 1, 2025
60 checks passed
TheDanDan pushed a commit to Wengxin04/superset-cscd01project that referenced this pull request Dec 2, 2025
Facyla pushed a commit to Facyla/superset-contrib that referenced this pull request Dec 16, 2025
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants