fix: CI failures caused by a ruff version mismatch - #36358
Conversation
Code Review Agent Run #f6dc51Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36358 +/- ##
===========================================
+ Coverage 0 67.99% +67.99%
===========================================
Files 0 636 +636
Lines 0 46824 +46824
Branches 0 5083 +5083
===========================================
+ Hits 0 31837 +31837
- Misses 0 13707 +13707
- Partials 0 1280 +1280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
811677f to
db14a74
Compare
db14a74 to
26a453f
Compare
SUMMARY
Fixes CI failures caused by a ruff version mismatch between
requirements/development.txt(0.8.0) and.pre-commit-config.yaml(0.9.7). The two versions format code differently, causing "files were modified by this hook" failures when CI runs pre-commit.Changes:
docker/*fromisortchecks. These configuration files importsuperset_config, a local module in the same directory. Ruff's import classification varies by environment: locally it's classified as local-folder, while on CI (after dependencies are installed) it's classified as third-party. This causes ruff to want a blank line between imports locally but no blank line on CI, resulting in conflicting fixes. Excluding docker config files fromisortavoids this environment-dependent inconsistency.This ensures local development and CI always use the same ruff version, preventing future drift.
TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION