docs(llms): add PR template guidelines to LLMS.md - #35148
Merged
Conversation
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx | ✅ |
| superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
eschutho
force-pushed
the
docs/add-pr-template-to-claude-md
branch
from
September 15, 2025 21:57
1fafe49 to
131a1e2
Compare
sadpandajoe
reviewed
Sep 15, 2025
| - [ ] Removes existing feature or API | ||
| ``` | ||
|
|
||
| **PR Title Convention**: Follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) |
Member
There was a problem hiding this comment.
nit: do we need this or can we point this to the linter and use code as documentation for this? Same as above for the template.
Member
Author
There was a problem hiding this comment.
Yeah, that's prob not necessary
Member
Author
There was a problem hiding this comment.
Although I suppose it can help get it right the first time rather than wait for CI.
sadpandajoe
approved these changes
Sep 15, 2025
Added Pull Request guidelines section to LLMS.md that instructs LLM tools to: - Always read the current PR template from `.github/PULL_REQUEST_TEMPLATE.md` - Use all required template sections (SUMMARY, TESTING INSTRUCTIONS, etc.) - Follow Conventional Commits specification for PR titles This approach ensures LLMs always use the most up-to-date PR template format rather than relying on potentially outdated cached content. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
eschutho
force-pushed
the
docs/add-pr-template-to-claude-md
branch
from
September 15, 2025 22:36
131a1e2 to
b9c3bf8
Compare
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added comprehensive Pull Request guidelines section to LLMS.md (which CLAUDE.md symlinks to) to help LLM tools create properly formatted PRs that follow Superset conventions.
The new section includes:
This ensures consistent PR creation when using Claude Code and other LLM tools by providing clear instructions on how to format PR descriptions and titles according to project standards.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Documentation only change
TESTING INSTRUCTIONS
.github/PULL_REQUEST_TEMPLATE.mdADDITIONAL INFORMATION
🤖 Generated with Claude Code