Skip to content

fix(ag-grid): Fix broken string column filters in AG Grid Table V2 #34686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

amaannawab923
Copy link
Contributor

@amaannawab923 amaannawab923 commented Aug 14, 2025

SUMMARY

After migrating from v33 to v34 , the Column Filters stopped working for Text Column Filters , have fixed the same by returning correct Filter Type as expected in ag grid v34

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create a Table V2 with a string column in Dimensions
  2. Try to open its filter , and you will be presented with an error Cannot read properties of undefined (reading 'model')
    TypeError: Cannot read properties of undefined (reading 'model')

Before:

Screenshot 2025-08-14 at 9 06 33 AM Screenshot 2025-08-14 at 9 06 51 AM

After:
The column Filter opens correctly now for String Columns

Screenshot 2025-08-14 at 9 08 10 AM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useColDefs.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@amaannawab923 amaannawab923 changed the title fix(ag-grid): Text Column Filter fix(ag-grid): Fix broken string column filters in AG Grid Table V2 Aug 14, 2025
@geido geido merged commit 2179081 into apache:master Aug 18, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants