fix(utils): ensure webdriver timeout compatibility with urllib3 2.x - #34440
Merged
Conversation
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Over-permissive Timeout Key Matching ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/utils/webdriver.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+288
to
+287
| for key, value in config.items(): | ||
| if any(timeout_key in key.lower() for timeout_key in timeout_keys): |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
eschutho
force-pushed
the
elizabeth/urllib-compat
branch
from
August 1, 2025 19:48
7a5040c to
2c0455e
Compare
Prasad-JB
pushed a commit
to Prasad-JB/superset
that referenced
this pull request
Sep 8, 2025
aminghadersohi
pushed a commit
to aminghadersohi/superset
that referenced
this pull request
Jan 17, 2026
…pache#34440) (cherry picked from commit 385471c)
aminghadersohi
pushed a commit
to aminghadersohi/superset
that referenced
this pull request
Jan 24, 2026
…pache#34440) (cherry picked from commit 385471c)
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes compatibility issues with urllib3 2.x in the webdriver utility by ensuring timeout values are properly converted to float types. The urllib3 library now requires strict type checking for timeout parameters, and string/invalid timeout values were causing failures.
The changes include:
createmethod to reduce complexity (addressing ruff C901 error)TESTING INSTRUCTIONS
To run the new unit tests:
bash
pytest tests/unit_tests/utils/webdriver_test.py -v
ADDITIONAL INFORMATION
🤖 Generated with Claude Code
Co-Authored-By: Claude