fix: use catalog name on generated queries #34360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
betodealmeida
force-pushed
the
catalog-on-generated-query
branch
2 times, most recently
from
8fd6f23 to
9e0531b
Compare
betodealmeida
force-pushed
the
catalog-on-generated-query
branch
from
9e0531b to
50babc1
Compare
3 tasks
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Cross-catalog Query Support Rationale Missing ▹ view | 🧠 Incorrect |
Files scanned
| File Path | Reviewed |
|---|---|
| docker/pythonpath_dev/superset_config_docker_light.py | ✅ |
| superset/connectors/sqla/models.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
1370
to
+1373
| def get_sqla_table(self) -> TableClause: | ||
| tbl = table(self.table_name) | ||
| # For databases that support cross-catalog queries (like BigQuery), | ||
| # include the catalog in the table identifier to generate | ||
| # project.dataset.table format |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
3 tasks
betodealmeida
force-pushed
the
catalog-on-generated-query
branch
from
dc449c7 to
fc38150
Compare
eschutho
approved these changes
Jul 29, 2025
mistercrunch
approved these changes
Jul 29, 2025
betodealmeida
force-pushed
the
catalog-on-generated-query
branch
from
6646b24 to
dda17ec
Compare
betodealmeida
force-pushed
the
catalog-on-generated-query
branch
from
dda17ec to
16ddb4f
Compare
sadpandajoe
added
the
review:checkpoint
rusackas
removed
the
review:checkpoint
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When generating SQL in Explore, use the dataset catalog name in the query if it has one and the dialect supports the
catalog.schema.tableidentifier structure (DB engine spec hassupports_cross_catalog_queries=True).Fixes #33465.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION