SPARK-1790: Update EC2 scripts to support r3 instance types #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
|
||
| return ami | ||
|
|
||
| instance_types = { |
There was a problem hiding this comment.
This shouldn't change the indentation. We use the PEP8 style guide which requires 4 spaces.
There was a problem hiding this comment.
ahh..my bad will send another one...
|
Updated the pull request to fix indentation. Sorry my editor settings were not right. |
| "r3.xlarge": "hvm", | ||
| "r3.2xlarge": "hvm", | ||
| "r3.4xlarge": "hvm", | ||
| "r3.8xlarge": "hvm", |
There was a problem hiding this comment.
Nit, but I think we shouldn't have a trailing comma here for the last entry. PEP 8 doesn't say this explicitly, but it has it in all the examples.
asfgit
pushed a commit
that referenced
this pull request
Jun 4, 2014
Author: Varakhedi Sujeet <[email protected]> Closes #960 from sujeetv/ec2-r3 and squashes the following commits: 3cb9fd5 [Varakhedi Sujeet] SPARK-1790: Update EC2 scripts to support r3 instance (cherry picked from commit 11ded3f) Conflicts: ec2/spark_ec2.py
asfgit
pushed a commit
that referenced
this pull request
Jun 4, 2014
Author: Varakhedi Sujeet <[email protected]> Closes #960 from sujeetv/ec2-r3 and squashes the following commits: 3cb9fd5 [Varakhedi Sujeet] SPARK-1790: Update EC2 scripts to support r3 instance (cherry picked from commit 11ded3f) Conflicts: ec2/spark_ec2.py
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
Author: Varakhedi Sujeet <[email protected]> Closes apache#960 from sujeetv/ec2-r3 and squashes the following commits: 3cb9fd5 [Varakhedi Sujeet] SPARK-1790: Update EC2 scripts to support r3 instance
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Author: Varakhedi Sujeet <[email protected]> Closes apache#960 from sujeetv/ec2-r3 and squashes the following commits: 3cb9fd5 [Varakhedi Sujeet] SPARK-1790: Update EC2 scripts to support r3 instance
agirish
pushed a commit
to HPEEzmeral/apache-spark
that referenced
this pull request
May 5, 2022
udaynpusa
pushed a commit
to mapr/spark
that referenced
this pull request
Jan 30, 2024
mapr-devops
pushed a commit
to mapr/spark
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.